Actions
coordination #44075
closed[functional][y][epic] Use more static code style checks to make life for test developers such a pain that nobody dares to add new tests which we would not be able to maintain anyway ;)
Status:
Resolved
Priority:
Normal
Assignee:
Category:
Enhancement to existing tests
Target version:
SUSE QA - Milestone 25
Start date:
2018-11-21
Due date:
2019-06-04
% Done:
100%
Estimated time:
(Total: 12.00 h)
Difficulty:
Description
Motivation¶
https://etherpad.nue.suse.com/qa_sles_functional_retrospective sprint 29 about "supporting of all the possible scenarios, architectures and product versions in the same test module makes tests less readable, very hard to maintain".
Acceptance criteria¶
- AC1: Additional policies or tools have been evaluated and feasible ones implemented in the local tests
Suggestions¶
- Use more policies for Perl::Critic, e.g. https://metacpan.org/pod/Perl::Critic::Policy::ControlStructures::ProhibitDeepNests
- Check maximum file length, e.g. restrict the main.pm files
- Potentially use https://coala.io
Actions