Project

General

Profile

Actions

action #48599

closed

coordination #44075: [functional][y][epic] Use more static code style checks to make life for test developers such a pain that nobody dares to add new tests which we would not be able to maintain anyway ;)

[functional][y] Use Perl::Critic::Freenode perlcritic rules as in os-autoinst and openQA

Added by okurz about 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Enhancement to existing tests
Target version:
SUSE QA - Milestone 25
Start date:
2019-03-02
Due date:
2019-05-21
% Done:

0%

Estimated time:
5.00 h
Difficulty:

Description

Motivation

See https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6294#issuecomment-443167803

Acceptance criteria

  • AC1: automatic perlcritic checks in os-autoinst-distri-opensuse use Perl::Critic::Freenode rules

Suggestions

We need to enable rule and see if code requires adjustments
Package dependencies should be added to cpan dependencies list
Triggering check locally can be done by make perlcritic

Actions #1

Updated by riafarov about 5 years ago

  • Description updated (diff)
  • Estimated time set to 5.00 h
Actions #2

Updated by riafarov about 5 years ago

  • Due date changed from 2019-04-09 to 2019-04-23
Actions #3

Updated by JERiveraMoya about 5 years ago

  • Status changed from Workable to In Progress
  • Assignee set to JERiveraMoya
Actions #4

Updated by riafarov about 5 years ago

  • Status changed from In Progress to Workable
  • Assignee deleted (JERiveraMoya)

Let's unassign, as Joaquin is off.

Actions #5

Updated by riafarov almost 5 years ago

  • Due date changed from 2019-04-23 to 2019-05-07
Actions #6

Updated by riafarov almost 5 years ago

  • Due date changed from 2019-05-07 to 2019-05-21
Actions #7

Updated by riafarov almost 5 years ago

  • Target version changed from Milestone 24 to Milestone 25
Actions #8

Updated by JERiveraMoya almost 5 years ago

  • Status changed from Workable to Feedback
Actions #9

Updated by JERiveraMoya almost 5 years ago

  • Assignee set to JERiveraMoya
Actions #10

Updated by JERiveraMoya almost 5 years ago

  • Status changed from Feedback to Resolved

Applied successfully in Travis.

Actions

Also available in: Atom PDF