QA » openQA Project » openQA Tests

Perlcritic freenode already applied, so we can proceed with this ticket without problem to overlapping.

@ybonatakis, once you have installed perl-Perl-Critic-Freenode system-wise in your system, according to THEME-RULES it is possible to create themes combination.
Therefore we can modify .perlcriticrc as follows:

theme = freenode or complexity
severity = 4
...
[Perl::Critic::Policy::ControlStructures::ProhibitDeepNests]
severity = 4
max_nests = 4

So basically we can combine both themes and override ProhibitDeepNests with the severity that we are applying at the level of them plus max nests that we want. For instance if you include this test code:

my %my_hash = ('a' => b );
    my @bases_i;
    my @bases_j;
    my @bases_k;
    my @bases_l;
    my @bases_m;
    my @bases_n;
    my @bases_o;
    my @bases_p;
    my @bases_q;
    my @bases_r;
    foreach my $i (@bases_i) {
        foreach my $j (@bases_j) {
            foreach my $k (@bases_k) {
                foreach my $l (@bases_l) {
                    foreach my $m (@bases_m) {
                       my aa = 1;
                    }
                }
            }
        }
    }

You will see errors coming from both themes:
tests/path/to/module/you/decide/to/include/test/code.pm: Hash key with quotes at line 40, column 20. Avoid useless quotes. (Severity: 5)
tests/path/to/module/you/decide/to/include/test/code.pm: Code structure is deeply nested at line 60, column 41. Consider refactoring. (Severity: 4)

We have a couple of policies that we include as parameters in https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/Makefile#L104, I don't know the historic reasons for that, but they look like custom and in fact I can find the files for them in directory under tools. We could also add there another include for the policy of nested loop and it would work as well, but we should focus on make it work using perlcriticrc.
I hope it helps, you just need to play around with it and check that we don't miss anything.