coordination #44075: [functional][y][epic] Use more static code style checks to make life for test developers such a pain that nobody dares to add new tests which we would not be able to maintain anyway ;) - openQA Tests (public) - openSUSE Project Management Tool

Actions

Copy link

coordination #44075

closed

[functional][y][epic] Use more static code style checks to make life for test developers such a pain that nobody dares to add new tests which we would not be able to maintain anyway ;)

Added by okurz about 6 years ago. Updated over 4 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

riafarov

Category:

Enhancement to existing tests

Target version:

SUSE QA (private) - Milestone 25

Start date:

2018-11-21

Due date:

2019-06-04

% Done:

100%

Estimated time:

(Total: 12.00 h)

Difficulty:

Description

Motivation¶

https://etherpad.nue.suse.com/qa_sles_functional_retrospective sprint 29 about "supporting of all the possible scenarios, architectures and product versions in the same test module makes tests less readable, very hard to maintain".

Acceptance criteria¶

AC1: Additional policies or tools have been evaluated and feasible ones implemented in the local tests

Suggestions¶

Use more policies for Perl::Critic, e.g. https://metacpan.org/pod/Perl::Critic::Policy::ControlStructures::ProhibitDeepNests
Check maximum file length, e.g. restrict the main.pm files
Potentially use https://coala.io

Subtasks 7 (0 open — 7 closed)

action #44159: [functional][y][timeboxed:4h] Use more static code style checks - evaluate what perl critic policies make sense

Resolved

JERiveraMoya

2018-11-21

2018-12-04

Actions

action #44165: [functional][y] Use more static code style checks - try to use https://metacpan.org/pod/Perl::Critic::Policy::ControlStructures::ProhibitDeepNests

Resolved

JERiveraMoya

2018-11-21

2018-12-04

Actions

action #44528: [functional][y] Understand why "perlcritic" was not run for a long time

Resolved

riafarov

2018-11-29

2019-02-12

Actions

action #47012: [functional][u] Summary or Maintainer info missing from test modules

Resolved

okurz

2019-02-01

2019-03-26

Actions

action #48599: [functional][y] Use Perl::Critic::Freenode perlcritic rules as in os-autoinst and openQA

Resolved

JERiveraMoya

2019-03-02

2019-05-21

Actions

action #48602: [functional][y] Limit maximum file length with static code checks

Rejected

riafarov

2019-03-02

Actions

action #48605: [functional][y] Reduce code nesting level to a limit of 4

Resolved

ybonatakis

2019-03-02

2019-06-04

Actions

Copy link

Updated by riafarov about 6 years ago

Subject changed from [functional][y] Use more static code style checks to make life for test developers such a pain that nobody dares to add new tests which we would not be able to maintain anyway ;) to [epic][functional][y] Use more static code style checks to make life for test developers such a pain that nobody dares to add new tests which we would not be able to maintain anyway ;)

Actions

Copy link

Updated by okurz about 6 years ago

More ideas:

Actions

Copy link

Updated by okurz about 6 years ago

Subject changed from [epic][functional][y] Use more static code style checks to make life for test developers such a pain that nobody dares to add new tests which we would not be able to maintain anyway ;) to [functional][y][epic] Use more static code style checks to make life for test developers such a pain that nobody dares to add new tests which we would not be able to maintain anyway ;)

Actions

Copy link