Project

General

Profile

Actions
Copy link

action #44528

closed

coordination #44075: [functional][y][epic] Use more static code style checks to make life for test developers such a pain that nobody dares to add new tests which we would not be able to maintain anyway ;)

[functional][y] Understand why "perlcritic" was not run for a long time

Added by okurz over 5 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
riafarov
Category:
Enhancement to existing tests
Target version:
SUSE QA - Milestone 22
Start date:
2018-11-29
Due date:
2019-02-12
% Done:

0%

Estimated time:
Difficulty:

Description

Motivation

See https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6294#issuecomment-442803506

Acceptance criteria

  • AC1: Research has been conducted why perlcritic was not applied for PR checks
  • AC2: Ensure Makefile already includes what really works regarding perlcritic

Suggestions

  • Find out from git log and history of travis jobs or by test bisecting when was the last time perlcritic tests were conducted as part of travis CI jobs on the master branch and/or pull requests. If you want to go the route of "test bisecting" I suggest to find a simple patch that introduces something that perlcritic would complain about, e.g. write use foo qw(bar) which perlcritic complains about because we prefer use foo 'bar'. Then apply this patch and call make test as part of git bisect run … between the commit that initially introduced perlcritic checks and the current one (or the one from jeriveramoya that fixed it recently)
  • Depending on the cause of the regression find out if the Makefile has code without an effect and fix it or if the last fix actually already covered this as well so that there is only effective code included
Actions
Copy link
 #1

Updated by okurz over 5 years ago

  • Due date set to 2019-02-12

pre-fill last sprint in M22 with all tickets within milestone not yet assigned to sprints

Actions
Copy link
 #2

Updated by okurz over 5 years ago

  • Description updated (diff)
  • Status changed from New to Workable
Actions
Copy link
 #3

Updated by riafarov over 5 years ago

  • Status changed from Workable to Resolved
  • Assignee set to riafarov

I was not able to identify any change, seems that since perltidy check was introduced: https://github.com/os-autoinst/os-autoinst-distri-opensuse/commit/dc6a403221 it was never enabled on travis

Actions
Copy link
 #4

Updated by okurz over 5 years ago

That's confusing because the target test-merge mentions perlcritic explicitly. But, ok, thanks for your investigation and crosschecking. At least the QSF-y was the hero team that re-introduced perlcritic checks, have failures fixed and extended the tests :)

Actions
Copy link

Also available in: Atom PDF