action #55580
open[qe-core][functional] Refactor susedistribution::x11_start_program to support command not found (and retry)
0%
Description
As a result of poo#54401, and https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8192 the proposed solution would help if spread to other areas. So making it more generic, and allow x11_start_program to support mistyping.
Suggestions¶
- In the case of xterm, when command is not found, use
clearinstead ofesc. - In the case of application launchers, press
escensure desktop is matched, and try again like it was implemented for firefox_audio.
Starting with application launchers would/should be the easier way to start. Building a small matrix of the desktops where it would be supported, would help a lot.
Tasks¶
- Building a small matrix of the desktops where it would be supported
- Move the for loop of the retry inside x11_start_program
Supported Desktops¶
- Gnome
- KDE
- MinimalX (not yet verified)
Updated by mgriessmeier over 4 years ago
- Target version changed from Milestone 26 to Milestone 27
to be groomed
Updated by SLindoMansilla over 4 years ago
- Description updated (diff)
- Status changed from New to Workable
- Priority changed from High to Normal
- Target version changed from Milestone 27 to Milestone 28
Updated by SLindoMansilla over 4 years ago
PR: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8403
Missing task 1: Building a small matrix of the desktops where it would be supported
Updated by jorauch over 4 years ago
Well that should be every desktop where 'esc' closes the runner
Updated by szarate over 4 years ago
jorauch wrote:
Well that should be every desktop where 'esc' closes the runner
And which ones are those? :P, because the xterm case, is not a desktop per sé :P
(Sorry for the nipticking but having a matrix would really help in the future, even if right now, feels silly and short...)
Updated by jorauch over 4 years ago
Supported Desktops (Draft, to be extended and some to be verified):
- Gnome
- KDE
- MinimalX (to be verified)
Updated by jorauch over 4 years ago
- Description updated (diff)
- Status changed from In Progress to Feedback
Added Basic list of supported desktops
Updated by jorauch over 4 years ago
PR merged, waiting a bit to see if someone complains
Updated by favogt over 4 years ago
jorauch wrote:
PR merged, waiting a bit to see if someone complains
It broke the dolphin test in all scenarios. It presses Esc before Alt-F2 to open the runner, which must not happen as it messes with whatever window is in focus.
I'll open a PR for reverting.
Updated by okurz over 4 years ago
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8613 is the revert, merged.
Updated by jorauch over 4 years ago
New PR that already got merged: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8633
Updated by okurz over 4 years ago
another revert merged: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8723
Updated by jorauch over 4 years ago
- Status changed from Feedback to In Progress
Back to the beginning then
Updated by jorauch over 4 years ago
- Blocked by action #59241: [sle][functional][u] test fails in libqt5_qtbase - pkcon giving a false positive added
Updated by jorauch over 4 years ago
- Status changed from In Progress to Blocked
We should really rework the whole function and not just try to tinker around with the existing workarounds
After fixing the blocker we should discuss this ticket with slindomansilla, okurz and whoever is interested
Updated by jorauch over 4 years ago
- Status changed from Blocked to Feedback
Blocker rejected, lets discuss this soonish
Updated by mgriessmeier over 4 years ago
- Target version changed from Milestone 28 to Milestone 30
needs to be discussed offline
Updated by tjyrinki_suse over 3 years ago
- Subject changed from [functional][u] Refactor susedistribution::x11_start_program to support command not found (and retry) to [qe-core][functional] Refactor susedistribution::x11_start_program to support command not found (and retry)
Updated by okurz over 2 years ago
I came to this ticket due to periodically reviewing tickets as described on https://progress.opensuse.org/projects/openqatests/wiki#How-we-work-on-tickets
This ticket was set to "Normal" priority but was not updated within the SLO period for "Normal" tickets (365 days) as described on https://progress.opensuse.org/projects/openqatests/wiki/Wiki#SLOs-service-level-objectives
First reminder: Please consider picking up this ticket within the next 365 days or just set the ticket to the next lower priority of "Low" (no SLO related time period).
Updated by zluo about 2 years ago
- Assignee deleted (
jorauch) - Start date deleted (
2019-08-15)
Jorauch has left SUSE a long time ago, so un-assign him of course.
Updated by slo-gin about 1 month ago
This ticket was set to Normal priority but was not updated within the SLO period. Please consider picking up this ticket or just set the ticket to the next lower priority.