[qe-core][functional] Refactor susedistribution::x11_start_program to support command not found (and retry)
As a result of poo#54401, and https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8192 the proposed solution would help if spread to other areas. So making it more generic, and allow
x11_start_program to support mistyping.
- In the case of xterm, when command is not found, use
- In the case of application launchers, press
escensure desktop is matched, and try again like it was implemented for firefox_audio.
Starting with application launchers would/should be the easier way to start. Building a small matrix of the desktops where it would be supported, would help a lot.
- Building a small matrix of the desktops where it would be supported
- Move the for loop of the retry inside x11_start_program
- MinimalX (not yet verified)
#6 Updated by SLindoMansilla about 2 years ago
Missing task 1: Building a small matrix of the desktops where it would be supported
#8 Updated by szarate about 2 years ago
Well that should be every desktop where 'esc' closes the runner
And which ones are those? :P, because the xterm case, is not a desktop per sé :P
(Sorry for the nipticking but having a matrix would really help in the future, even if right now, feels silly and short...)
#12 Updated by favogt almost 2 years ago
PR merged, waiting a bit to see if someone complains
It broke the dolphin test in all scenarios. It presses Esc before Alt-F2 to open the runner, which must not happen as it messes with whatever window is in focus.
I'll open a PR for reverting.
#13 Updated by okurz almost 2 years ago
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8613 is the revert, merged.
#14 Updated by jorauch almost 2 years ago
New PR that already got merged: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8633
#15 Updated by okurz almost 2 years ago
another revert merged: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8723