action #55580

[functional][u] Refactor susedistribution::x11_start_program to support command not found (and retry)

Added by szarate 5 months ago. Updated 14 days ago.

Status:FeedbackStart date:15/08/2019
Priority:NormalDue date:
Assignee:jorauch% Done:

0%

Category:Enhancement to existing testsEstimated time:42.00 hours
Target version:SUSE QA tests - Milestone 30
Difficulty:medium
Duration:

Description

As a result of poo#54401, and https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8192 the proposed solution would help if spread to other areas. So making it more generic, and allow x11_start_program to support mistyping.

Suggestions

  • In the case of xterm, when command is not found, use clear instead of esc.
  • In the case of application launchers, press esc ensure desktop is matched, and try again like it was implemented for firefox_audio.

Starting with application launchers would/should be the easier way to start. Building a small matrix of the desktops where it would be supported, would help a lot.

Tasks

  1. Building a small matrix of the desktops where it would be supported
  2. Move the for loop of the retry inside x11_start_program

Supported Desktops

  • Gnome
  • KDE
  • MinimalX (not yet verified)

Related issues

Blocked by openQA Tests - action #59241: [sle][functional][u] test fails in libqt5_qtbase - pkcon ... Rejected 08/11/2019

History

#1 Updated by mgriessmeier 5 months ago

  • Target version changed from Milestone 26 to Milestone 27

to be groomed

#2 Updated by SLindoMansilla 5 months ago

  • Description updated (diff)
  • Status changed from New to Workable
  • Priority changed from High to Normal
  • Target version changed from Milestone 27 to Milestone 28

#3 Updated by SLindoMansilla 5 months ago

  • Estimated time set to 42.00

#4 Updated by jorauch 5 months ago

  • Assignee set to jorauch

#5 Updated by jorauch 5 months ago

  • Status changed from Workable to In Progress

#6 Updated by SLindoMansilla 4 months ago

PR: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8403

Missing task 1: Building a small matrix of the desktops where it would be supported

#7 Updated by jorauch 4 months ago

Well that should be every desktop where 'esc' closes the runner

#8 Updated by szarate 4 months ago

jorauch wrote:

Well that should be every desktop where 'esc' closes the runner

And which ones are those? :P, because the xterm case, is not a desktop per sé :P

(Sorry for the nipticking but having a matrix would really help in the future, even if right now, feels silly and short...)

#9 Updated by jorauch 4 months ago

Supported Desktops (Draft, to be extended and some to be verified):
- Gnome
- KDE
- MinimalX (to be verified)

#10 Updated by jorauch 4 months ago

  • Description updated (diff)
  • Status changed from In Progress to Feedback

Added Basic list of supported desktops

#11 Updated by jorauch 3 months ago

PR merged, waiting a bit to see if someone complains

#12 Updated by favogt 3 months ago

jorauch wrote:

PR merged, waiting a bit to see if someone complains

It broke the dolphin test in all scenarios. It presses Esc before Alt-F2 to open the runner, which must not happen as it messes with whatever window is in focus.

I'll open a PR for reverting.

#16 Updated by jorauch 3 months ago

  • Status changed from Feedback to In Progress

Back to the beginning then

#17 Updated by jorauch 2 months ago

  • Blocked by action #59241: [sle][functional][u] test fails in libqt5_qtbase - pkcon giving a false positive added

#18 Updated by jorauch 2 months ago

  • Status changed from In Progress to Blocked

We should really rework the whole function and not just try to tinker around with the existing workarounds
After fixing the blocker we should discuss this ticket with slindomansilla, okurz and whoever is interested

#19 Updated by jorauch about 1 month ago

  • Status changed from Blocked to Feedback

Blocker rejected, lets discuss this soonish

#20 Updated by mgriessmeier 14 days ago

  • Target version changed from Milestone 28 to Milestone 30

needs to be discussed offline

Also available in: Atom PDF