Project

General

Profile

Actions
Copy link

action #55703

closed

send_keys() doesn't guarantee that the application will handle modifiers+normal_key properly

Added by SLindoMansilla over 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
coolo
Category:
Feature requests
Target version:
Current Sprint
Start date:
2019-04-15
Due date:
% Done:

100%

Estimated time:
(Total: 126.00 h)

Description

Observation

After several issues with "missing keys" when modifiers+normal_keys are involved, we realized that we can reproduced the same issues that openQA was showing by manually pressing the two keys simultaneosly. Those experiments, while far from being a scientific prove, help us understand what could be going wrong.

Different applications handles those keys different (eg. gedit, firefox).

Suggestion

  • Be sure that when using send_keys(), they are sent in the positional order. (eg. if alt-a is sent, alt should be sent first and then 'a', with enough time to let the application handles them.
  • Check with coolo about implementation of the VNC wrapper.

Subtasks 4 (0 open — 4 closed)

action #54422: [functional][u] LO recent documents: alt-f not working on wayland (TW)Resolved2019-07-18

Actions
openQA Tests - action #50399: [functional][y] Installer doesn't react to key pressClosedriafarov2019-04-15

Actions
openQA Tests - action #54425: [functional][u] hexchat: ctrl-a mis-interpreted as 'a' since we switched to QEMUVGA "std"Resolveddimstar2019-07-18

Actions
action #57077: [functional][u][sporadic] test fails in vlc - open network protocol setting page is unreliable with ctrl-nResolvedcoolo2019-09-19

Actions

Related issues 3 (1 open — 2 closed)

Related to openQA Tests - action #39926: [functional][u][sporadic][virtio] test fails in vlc - vlc is started twice, needle target_match_vlc seems wrongRejected2018-08-17

Actions
Related to openQA Tests - coordination #43889: [qe-core][epic][functional][virtio][wayland] openQA makes spelling mistakesBlocked

Actions
Related to openQA Tests - action #54056: [functional][u] test fails in virtman_viewResolvedzluo2019-07-10

Actions
Actions
Copy link
 #1

Updated by SLindoMansilla over 4 years ago

  • Subject changed from [epic] send_keys() doesn't guarantee that the application will handle modifiers+normal_key properly to [epic][functional][u] send_keys() doesn't guarantee that the application will handle modifiers+normal_key properly
Actions
Copy link
 #2

Updated by SLindoMansilla over 4 years ago

  • Status changed from New to Workable

Sub-Tasks in place

Actions
Copy link
 #3

Updated by SLindoMansilla over 4 years ago

  • Related to action #39926: [functional][u][sporadic][virtio] test fails in vlc - vlc is started twice, needle target_match_vlc seems wrong added
Actions
Copy link
 #4

Updated by SLindoMansilla over 4 years ago

  • Related to coordination #43889: [qe-core][epic][functional][virtio][wayland] openQA makes spelling mistakes added
Actions
Copy link
 #5

Updated by SLindoMansilla over 4 years ago

  • Assignee changed from SLindoMansilla to mgriessmeier
Actions
Copy link
 #6

Updated by zluo over 4 years ago

  • Blocks action #54056: [functional][u] test fails in virtman_view added
Actions
Copy link
 #8

Updated by zluo over 4 years ago

it seems that the PR doesn't solve our issue: #54056: [functional][u] test fails in virtman_view

Actions
Copy link
 #9

Updated by coolo over 4 years ago

  • Blocks deleted (action #54056: [functional][u] test fails in virtman_view)
Actions
Copy link
 #10

Updated by coolo over 4 years ago

  • Project changed from openQA Tests to openQA Project
  • Subject changed from [epic][functional][u] send_keys() doesn't guarantee that the application will handle modifiers+normal_key properly to send_keys() doesn't guarantee that the application will handle modifiers+normal_key properly
  • Category changed from Bugs in existing tests to Feature requests
  • Status changed from Workable to New
  • Assignee deleted (mgriessmeier)
  • Target version set to Ready

https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8862 shows that send_key('alt-v') is too fast in cases. We should either make combinations of keys generally a lot slower or provide an option to do so.

Actions
Copy link
 #11

Updated by SLindoMansilla over 4 years ago

  • Related to action #54056: [functional][u] test fails in virtman_view added
Actions
Copy link
 #12

Updated by SLindoMansilla over 4 years ago

The relation helps us in our queries to know that someone is working on that so that we don't duplicate tickets/efforts

Actions
Copy link
 #13

Updated by coolo over 4 years ago

I just removed the 'blocked by' as it's obviously not blocked by this - as seen by the PR

Actions
Copy link
 #14

Updated by ggardet_arm over 4 years ago

send_key does not care about VNC_TYPING_LIMIT contrary to type_string.

We could try to update send_key to respect VNC_TYPING_LIMIT and if it is not enough, we could implement a slow_send_key or add an arg to send_key to adjust it, as suggested by @coolo.

Actions
Copy link
 #15

Updated by okurz over 4 years ago

that sounds like a very good idea.

Actions
Copy link
 #16

Updated by coolo over 4 years ago

I would make the default slower in general - the typing limit should be respected nonetheless

Actions
Copy link
 #18

Updated by okurz over 4 years ago

  • Status changed from New to Feedback
  • Assignee set to coolo
  • Target version changed from Ready to Current Sprint

coolo created a spin-off in https://github.com/os-autoinst/os-autoinst/pull/1260 . @coolo can you track this with it's effect on production?

Actions
Copy link
 #19

Updated by coolo over 4 years ago

  • Status changed from Feedback to Resolved

we're good. So far no complains about typing too slow - and actually fixing some cases

Actions
Copy link

Also available in: Atom PDF