Project

General

Profile

Actions
Copy link

action #51230

closed

coordination #51224: [qe-core][functional][epic] Unify code logic for systemd related functionality

[qe-core][functional] Unify all usages of systemctl

Added by SLindoMansilla almost 6 years ago. Updated about 2 months ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
Enhancement to existing tests
Target version:
-
Start date:
2019-05-07
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

Motivation

In the code there are divergences about using the systemctl function defined in utils and the usage of script_run('systemctl...').
This ticket is about unifying this code logic to always use the test function systemctl instead of script_run.

Acceptance criteria

  • AC1: There is no module executing script_run('systemctl ...')
  • AC2: All usages of script_run('systemctl ...') are replaced to systemctl('...')
  • AC3: An RFC with an automated check is added to avoid introducing again, mixed syntax (see #96675 and it's acceptance criteria)

Further information

reg_exp_before = /^\s*\w*script_run[( ]['"]systemctl.*$/
reg_exp_after = /^\s*systemctl[( ]['"].*$/

Related issues 3 (1 open — 2 closed)

Related to openQA Tests (public) - coordination #96596: [qe-core][CI] CI/CD and Coding style improvementsFeedbackmgrifalconi2019-12-11

Actions
Blocked by openQA Tests (public) - action #51227: [functional][u] Move function systemctl from lib/utils.pm to lib/Utils/Systemd.pmResolvedzluo2019-05-07

Actions
Blocks openQA Tests (public) - action #51233: [qe-core][functional] Unify logic for disable_and_stop_serviceRejected2019-05-07

Actions
Actions
Copy link
 #1

Updated by SLindoMansilla almost 6 years ago

  • Blocked by action #51227: [functional][u] Move function systemctl from lib/utils.pm to lib/Utils/Systemd.pm added
Actions
Copy link
 #2

Updated by SLindoMansilla almost 6 years ago

  • Status changed from New to Blocked

Blocked by #51227

Actions
Copy link
 #3

Updated by SLindoMansilla almost 6 years ago

  • Blocks action #51233: [qe-core][functional] Unify logic for disable_and_stop_service added
Actions
Copy link
 #4

Updated by tjyrinki_suse over 4 years ago

  • Subject changed from [functional][u] Unify all usages of systemctl to [qe-core][functional] Unify all usages of systemctl
Actions
Copy link
 #5

Updated by okurz over 3 years ago

  • Priority changed from High to Normal

This ticket was set to "High" priority but was not updated within 120 days which is 4 times the period of the SLO for "High" tickets (30 days) as described on https://progress.opensuse.org/projects/openqatests/wiki/Wiki#SLOs-service-level-objectives . The ticket will be set to the next lower priority of "Normal".

Actions
Copy link
 #6

Updated by szarate almost 3 years ago

Actions
Copy link
 #7

Updated by szarate almost 3 years ago

  • Description updated (diff)
Actions
Copy link
 #8

Updated by slo-gin about 1 year ago

This ticket was set to Normal priority but was not updated within the SLO period. Please consider picking up this ticket or just set the ticket to the next lower priority.

Actions
Copy link
 #9

Updated by mgrifalconi about 2 months ago

  • Status changed from Blocked to Rejected

we have a new ticket to revisit systemd testing https://progress.opensuse.org/issues/174991

Actions
Copy link

Also available in: Atom PDF