Project

General

Profile

action #51230

coordination #51224: [qe-core][functional][epic] Unify code logic for systemd related functionality

[qe-core][functional] Unify all usages of systemctl

Added by SLindoMansilla about 4 years ago. Updated about 1 year ago.

Status:
Blocked
Priority:
Normal
Assignee:
-
Category:
Enhancement to existing tests
Target version:
-
Start date:
2019-05-07
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

Motivation

In the code there are divergences about using the systemctl function defined in utils and the usage of script_run('systemctl...').
This ticket is about unifying this code logic to always use the test function systemctl instead of script_run.

Acceptance criteria

  • AC1: There is no module executing script_run('systemctl ...')
  • AC2: All usages of script_run('systemctl ...') are replaced to systemctl('...')
  • AC3: An RFC with an automated check is added to avoid introducing again, mixed syntax (see #96675 and it's acceptance criteria)

Further information

reg_exp_before = /^\s*\w*script_run[( ]['"]systemctl.*$/
reg_exp_after = /^\s*systemctl[( ]['"].*$/

Related issues

Related to openQA Tests - coordination #96596: [qe-core][CI] CI/CD and Coding style improvementsBlocked2021-08-09

Blocked by openQA Tests - action #51227: [functional][u] Move function systemctl from lib/utils.pm to lib/Utils/Systemd.pmResolved2019-05-07

Blocks openQA Tests - action #51233: [qe-core][functional] Unify logic for disable_and_stop_serviceBlocked2019-05-07

History

#1 Updated by SLindoMansilla about 4 years ago

  • Blocked by action #51227: [functional][u] Move function systemctl from lib/utils.pm to lib/Utils/Systemd.pm added

#2 Updated by SLindoMansilla about 4 years ago

  • Status changed from New to Blocked

Blocked by #51227

#3 Updated by SLindoMansilla about 4 years ago

  • Blocks action #51233: [qe-core][functional] Unify logic for disable_and_stop_service added

#4 Updated by tjyrinki_suse over 2 years ago

  • Subject changed from [functional][u] Unify all usages of systemctl to [qe-core][functional] Unify all usages of systemctl

#5 Updated by okurz almost 2 years ago

  • Priority changed from High to Normal

This ticket was set to "High" priority but was not updated within 120 days which is 4 times the period of the SLO for "High" tickets (30 days) as described on https://progress.opensuse.org/projects/openqatests/wiki/Wiki#SLOs-service-level-objectives . The ticket will be set to the next lower priority of "Normal".

#6 Updated by szarate about 1 year ago

#7 Updated by szarate about 1 year ago

  • Description updated (diff)

Also available in: Atom PDF