action #51230
coordination #51224: [qe-core][functional][epic] Unify code logic for systemd related functionality
[qe-core][functional] Unify all usages of systemctl
0%
Description
Motivation¶
In the code there are divergences about using the systemctl function defined in utils and the usage of script_run('systemctl...')
.
This ticket is about unifying this code logic to always use the test function systemctl instead of script_run
.
Acceptance criteria¶
- AC1: There is no module executing
script_run('systemctl ...')
- AC2: All usages of
script_run('systemctl ...')
are replaced tosystemctl('...')
- AC3: An RFC with an automated check is added to avoid introducing again, mixed syntax (see #96675 and it's acceptance criteria)
Further information¶
reg_exp_before = /^\s*\w*script_run[( ]['"]systemctl.*$/ reg_exp_after = /^\s*systemctl[( ]['"].*$/
Related issues
History
#1
Updated by SLindoMansilla about 4 years ago
- Blocked by action #51227: [functional][u] Move function systemctl from lib/utils.pm to lib/Utils/Systemd.pm added
#3
Updated by SLindoMansilla about 4 years ago
- Blocks action #51233: [qe-core][functional] Unify logic for disable_and_stop_service added
#4
Updated by tjyrinki_suse over 2 years ago
- Subject changed from [functional][u] Unify all usages of systemctl to [qe-core][functional] Unify all usages of systemctl
#5
Updated by okurz almost 2 years ago
- Priority changed from High to Normal
This ticket was set to "High" priority but was not updated within 120 days which is 4 times the period of the SLO for "High" tickets (30 days) as described on https://progress.opensuse.org/projects/openqatests/wiki/Wiki#SLOs-service-level-objectives . The ticket will be set to the next lower priority of "Normal".
#6
Updated by szarate about 1 year ago
- Related to coordination #96596: [qe-core][CI] CI/CD and Coding style improvements added
#7
Updated by szarate about 1 year ago
- Description updated (diff)
One of the things is to also add, https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/12517/commits/b6e9bdda01534d6340a7809ca13dcd75b4ff085e
This can be handled in a subtask