Project

General

Profile

action #51227

coordination #51224: [qe-core][functional][epic] Unify code logic for systemd related functionality

[functional][u] Move function systemctl from lib/utils.pm to lib/Utils/Systemd.pm

Added by SLindoMansilla over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Enhancement to existing tests
Target version:
SUSE QA - Milestone 26
Start date:
2019-05-07
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

Motivation

utils.pm is too big.

Acceptance criteria

  • AC1: The function systemctl is only defined in Utils::Systemd
  • AC2: All modules that use systemctl are verified to work (use Utils::Systemd 'systemctl')
  • AC3: All modules that use systemctl have a specific function import for utils (like use utils 'zypper_call';)
  • AC4: None of the modules that use systemctl have a generic import for utils (use utils;)

Further details

There is an existing function called systemctl from lib/utils.pm
This function is used by many modules.
This ticket is about moving the existing systemctl function into the new library Utils::Systemd.


Related issues

Blocks openQA Tests - action #51230: [qe-core][functional] Unify all usages of systemctlBlocked2019-05-07

History

#1 Updated by SLindoMansilla over 3 years ago

  • Blocks action #51230: [qe-core][functional] Unify all usages of systemctl added

#2 Updated by okurz over 3 years ago

  • Description updated (diff)
  • Status changed from New to Workable
  • Priority changed from High to Normal
  • Target version set to Milestone 26

QSF-u grooming

#3 Updated by zluo over 3 years ago

  • Status changed from Workable to In Progress
  • Assignee set to zluo

take over

#4 Updated by zluo over 3 years ago

move function systemctl to Utils::Systemd and export it.

add

use testapi 'script_run'; 

into Systemd.pm

Add

use Utils::Systemd 'systemctl';

into utils.pm

check http://f40.suse.de/tests/3788

#5 Updated by zluo over 3 years ago

still failed. Need to add assert_script_run or more script_run related wrappers in Systemd.pm.

#6 Updated by zluo over 3 years ago

#8 Updated by zluo over 3 years ago

#9 Updated by zluo over 3 years ago

  • Status changed from In Progress to Feedback

All verification tests look good. PR commit message got update now:

https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/7569

#10 Updated by zluo over 3 years ago

to check TW as well for PR:

https://openqa.opensuse.org/tests/944853

#11 Updated by szarate over 3 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF