action #51227
closedcoordination #51224: [qe-core][functional][epic] Unify code logic for systemd related functionality
[functional][u] Move function systemctl from lib/utils.pm to lib/Utils/Systemd.pm
0%
Description
Motivation¶
utils.pm is too big.
Acceptance criteria¶
- AC1: The function systemctl is only defined in Utils::Systemd
- AC2: All modules that use systemctl are verified to work (
use Utils::Systemd 'systemctl') - AC3: All modules that use systemctl have a specific function import for utils (like
use utils 'zypper_call';) - AC4: None of the modules that use systemctl have a generic import for utils (
use utils;)
Further details¶
There is an existing function called systemctl from lib/utils.pm
This function is used by many modules.
This ticket is about moving the existing systemctl function into the new library Utils::Systemd.
Updated by SLindoMansilla almost 6 years ago
- Blocks action #51230: [qe-core][functional] Unify all usages of systemctl added
Updated by okurz almost 6 years ago
- Description updated (diff)
- Status changed from New to Workable
- Priority changed from High to Normal
- Target version set to Milestone 26
QSF-u grooming
Updated by zluo almost 6 years ago
- Status changed from Workable to In Progress
- Assignee set to zluo
take over
Updated by zluo almost 6 years ago
move function systemctl to Utils::Systemd and export it.
add
use testapi 'script_run';
into Systemd.pm
Add
use Utils::Systemd 'systemctl';
into utils.pm
Updated by zluo almost 6 years ago
still failed. Need to add assert_script_run or more script_run related wrappers in Systemd.pm.
Updated by zluo almost 6 years ago
works now:
http://f40.suse.de/tests/3791
http://f40.suse.de/tests/3795
http://f40.suse.de/tests/3790
create PR for verification tests on osd.
Updated by zluo almost 6 years ago
Updated by zluo almost 6 years ago
to check
https://openqa.suse.de/tests/2933467 (svirt-hyperv)
https://openqa.suse.de/tests/2933491 (64bit, gnome, yaml-schedule changes)
https://openqa.suse.de/tests/2924312 (svirt-xen-hvm)
https://openqa.suse.de/tests/2933464 (ppc64le)
Updated by zluo almost 6 years ago
- Status changed from In Progress to Feedback
All verification tests look good. PR commit message got update now:
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/7569
Updated by zluo almost 6 years ago
to check TW as well for PR: