Project

General

Profile

Actions

action #51230

open

coordination #51224: [qe-core][functional][epic] Unify code logic for systemd related functionality

[qe-core][functional] Unify all usages of systemctl

Added by SLindoMansilla almost 5 years ago. Updated about 1 month ago.

Status:
Blocked
Priority:
Normal
Assignee:
-
Category:
Enhancement to existing tests
Target version:
-
Start date:
2019-05-07
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

Motivation

In the code there are divergences about using the systemctl function defined in utils and the usage of script_run('systemctl...').
This ticket is about unifying this code logic to always use the test function systemctl instead of script_run.

Acceptance criteria

  • AC1: There is no module executing script_run('systemctl ...')
  • AC2: All usages of script_run('systemctl ...') are replaced to systemctl('...')
  • AC3: An RFC with an automated check is added to avoid introducing again, mixed syntax (see #96675 and it's acceptance criteria)

Further information

reg_exp_before = /^\s*\w*script_run[( ]['"]systemctl.*$/
reg_exp_after = /^\s*systemctl[( ]['"].*$/

Related issues 3 (2 open1 closed)

Related to openQA Tests - coordination #96596: [qe-core][CI] CI/CD and Coding style improvementsBlockedszarate2021-08-09

Actions
Blocked by openQA Tests - action #51227: [functional][u] Move function systemctl from lib/utils.pm to lib/Utils/Systemd.pmResolvedzluo2019-05-07

Actions
Blocks openQA Tests - action #51233: [qe-core][functional] Unify logic for disable_and_stop_serviceBlocked2019-05-07

Actions
Actions

Also available in: Atom PDF