action #28988
open
[qe-core][sle][functional] modify or drop scripted_run_slow function since it makes test module not fail on error
Added by Anonymous over 6 years ago.
Updated about 2 months ago.
Category:
Enhancement to existing tests
Target version:
SUSE QA - Milestone 30
Description
As observed from a test module zypper_lr_validation for SLE15 that although there were errors in the result from the command, the test module didn't register or show as failed. This may lead to the fact that we overlook serious issues. And the reason why it happened was that the command run_scripted_command_slow($cmd, slow_type => 2); didn't throw exception as one had expected, since it only calls type_string_very_slow and wait_serial but not assert_script_run.
acceptance criteria¶
- AC1: Modify (or drop) run_scripted_command_slow function so that a test module dies if the command didn't return zero.
tasks¶
- Modify or drop run_scripted_command_slow function
- Make sure the modules that called run_scripted_command_slow function still work afterwards
- Related to action #25450: [sle][functional][medium] test fails in zypper_lr_validate added
- Description updated (diff)
- Project changed from 46 to openQA Tests
- Category set to Enhancement to existing tests
- Target version set to Milestone 14
- Due date set to 2018-03-27
- Target version changed from Milestone 14 to Milestone 15
- Due date deleted (
2018-03-27)
- Target version changed from Milestone 15 to Milestone 17
sprint13 too full, just as well as M15 and M16
- Subject changed from [sle][functional]modify or drop scripted_run_slow function since it makes test module not fail on error to [sle][functional] modify or drop scripted_run_slow function since it makes test module not fail on error
- Target version changed from Milestone 17 to Milestone 21+
- Target version changed from Milestone 21+ to Milestone 21+
- Subject changed from [sle][functional] modify or drop scripted_run_slow function since it makes test module not fail on error to [sle][functional][u] modify or drop scripted_run_slow function since it makes test module not fail on error
- Target version changed from Milestone 21+ to future
- Status changed from New to Workable
- Priority changed from Normal to High
- Target version changed from future to Milestone 30
- Estimated time set to 42.00 h
Replace run_scripted_command_slow with assert_script_run
- Blocked by action #64806: [qe-core][functional] Implement slow_type parameter for assert_script_run added
- Status changed from Workable to Blocked
We only have one usage of this function (in tests/console/zypper_lr_validate.pm) so we decided to drop it completely and replace it with assert_script_run as soon as we have the slow typing feature there
- Subject changed from [sle][functional][u] modify or drop scripted_run_slow function since it makes test module not fail on error to [qe-core][sle][functional] modify or drop scripted_run_slow function since it makes test module not fail on error
- Priority changed from High to Normal
This ticket was set to Normal priority but was not updated within the SLO period. Please consider picking up this ticket or just set the ticket to the next lower priority.
This ticket was set to Normal priority but was not updated within the SLO period. Please consider picking up this ticket or just set the ticket to the next lower priority.
Also available in: Atom
PDF