Project

General

Profile

Actions
Copy link

action #64806

closed

[qe-core][functional] Implement slow_type parameter for assert_script_run

Added by jorauch about 4 years ago. Updated almost 3 years ago.

Status:
Rejected
Priority:
High
Assignee:
jorauch
Category:
Refactor/Code Improvements
Target version:
SUSE QA - Milestone 31
Start date:
Due date:
% Done:

0%

Estimated time:
42.00 h
Difficulty:
medium

Description

As we currently do not have the option to use slow typing speed for dedicated script runs we should implement this
This helps us to fix https://progress.opensuse.org/issues/28988

Related issues 1 (1 open — 0 closed)

Blocks openQA Tests - action #28988: [qe-core][sle][functional] modify or drop scripted_run_slow function since it makes test module not fail on errorBlockedjorauch2017-12-06

Actions
Actions
Copy link
 #1

Updated by jorauch about 4 years ago

  • Blocks action #28988: [qe-core][sle][functional] modify or drop scripted_run_slow function since it makes test module not fail on error added
Actions
Copy link
 #2

Updated by jorauch about 4 years ago

  • Status changed from New to In Progress
  • Target version set to Milestone 31
  • Estimated time set to 42.00 h
  • Difficulty set to medium
Actions
Copy link
 #3

Updated by okurz about 4 years ago

You might be able to simply

my $typing_limit = get_var('VNC_TYPING_LIMIT', '');
set_var('VNC_TYPING_LIMIT', $slow);
assert_script_run '$slow_command';
set_var('VNC_TYPING_LIMIT', $typing_limit);
Actions
Copy link
 #4

Updated by jorauch about 4 years ago

  • Status changed from In Progress to Feedback

Created PR:
https://github.com/os-autoinst/os-autoinst/pull/1380
Need further feedback

Actions
Copy link
 #5

Updated by tjyrinki_suse over 3 years ago

  • Subject changed from [functional][u] Implement slow_type parameter for assert_script_run to [qe-core][functional] Implement slow_type parameter for assert_script_run
Actions
Copy link
 #6

Updated by tjyrinki_suse about 3 years ago

  • Status changed from Feedback to Workable

Stalled since June 2020, but jorauch correctly stated in Dec in the PR "Lets not get this lost just because I lost focus.
All thats needed is a unit test"

This would be nice to finish, either by @jorauch or someone else, since we are still plagued by the typing issues.

Actions
Copy link
 #7

Updated by tjyrinki_suse about 3 years ago

jorauch estimates having possibly time for this in the summer 2021. If this is wanted before that, someone else could help finishing it.

Actions
Copy link
 #8

Updated by tjyrinki_suse almost 3 years ago

  • Start date deleted (2020-03-25)

Just a note: there's type_string_slow util, could be used?

Actions
Copy link
 #9

Updated by okurz almost 3 years ago

  • Status changed from Workable to Rejected

tjyrinki_suse wrote:

Just a note: there's type_string_slow util, could be used?

Not really because type_string_slow is implemented in os-autoinst-distri-opensuse so you can't easily call type_string_slow from within the os-autoinst call assert_script_run. But I suggest to simply reject this ticket. There is a reason why that "slow typing" is not that easily accessible within os-autoinst :) The "slow typing" should really only be used in case a user interface in the SUT is not able to cope with normal typing speeds, e.g. grub with its limited character buffer. People try to workaround problems of completely bogged down systems when the system is under heavy CPU or IO load but that can not be pinned down to individual locations but typing slow in all cases is ... well, slow :D So in general the real problems should be identified, not worked around.

Actions
Copy link

Also available in: Atom PDF