Project

General

Profile

action #28988

[sle][functional][u] modify or drop scripted_run_slow function since it makes test module not fail on error

Added by Anonymous almost 3 years ago. Updated 6 months ago.

Status:
Blocked
Priority:
High
Assignee:
Category:
Enhancement to existing tests
Target version:
SUSE QA tests - Milestone 30
Start date:
2017-12-06
Due date:
% Done:

0%

Estimated time:
42.00 h
Difficulty:

Description

As observed from a test module zypper_lr_validation for SLE15 that although there were errors in the result from the command, the test module didn't register or show as failed. This may lead to the fact that we overlook serious issues. And the reason why it happened was that the command run_scripted_command_slow($cmd, slow_type => 2); didn't throw exception as one had expected, since it only calls type_string_very_slow and wait_serial but not assert_script_run.

acceptance criteria

  • AC1: Modify (or drop) run_scripted_command_slow function so that a test module dies if the command didn't return zero.

tasks

  • Modify or drop run_scripted_command_slow function
  • Make sure the modules that called run_scripted_command_slow function still work afterwards

Related issues

Related to openQA Tests - action #25450: [sle][functional][medium] test fails in zypper_lr_validateResolved2017-09-202018-01-17

Blocked by openQA Tests - action #64806: [functional][u] Implement slow_type parameter for assert_script_runFeedback2020-03-25

History

#1 Updated by Anonymous almost 3 years ago

  • Related to action #25450: [sle][functional][medium] test fails in zypper_lr_validate added

#2 Updated by Anonymous almost 3 years ago

  • Description updated (diff)

#3 Updated by okurz almost 3 years ago

  • Project changed from SUSE QA tests to openQA Tests
  • Category set to Enhancement to existing tests
  • Target version set to Milestone 14

#4 Updated by okurz over 2 years ago

  • Due date set to 2018-03-27
  • Target version changed from Milestone 14 to Milestone 15

#5 Updated by okurz over 2 years ago

  • Due date deleted (2018-03-27)
  • Target version changed from Milestone 15 to Milestone 17

sprint13 too full, just as well as M15 and M16

#6 Updated by okurz over 2 years ago

  • Subject changed from [sle][functional]modify or drop scripted_run_slow function since it makes test module not fail on error to [sle][functional] modify or drop scripted_run_slow function since it makes test module not fail on error
  • Target version changed from Milestone 17 to Milestone 21+

#7 Updated by okurz over 2 years ago

  • Target version changed from Milestone 21+ to Milestone 21+

#8 Updated by okurz almost 2 years ago

  • Subject changed from [sle][functional] modify or drop scripted_run_slow function since it makes test module not fail on error to [sle][functional][u] modify or drop scripted_run_slow function since it makes test module not fail on error

#9 Updated by okurz over 1 year ago

  • Target version changed from Milestone 21+ to future

#10 Updated by szarate 6 months ago

  • Status changed from New to Workable
  • Priority changed from Normal to High
  • Target version changed from future to Milestone 30
  • Estimated time set to 42.00 h

Replace run_scripted_command_slow with assert_script_run

#11 Updated by jorauch 6 months ago

  • Assignee set to jorauch

#12 Updated by jorauch 6 months ago

  • Blocked by action #64806: [functional][u] Implement slow_type parameter for assert_script_run added

#13 Updated by jorauch 6 months ago

  • Status changed from Workable to Blocked

we need an adequate replacement first:
https://progress.opensuse.org/issues/64806

#14 Updated by jorauch 6 months ago

We only have one usage of this function (in tests/console/zypper_lr_validate.pm) so we decided to drop it completely and replace it with assert_script_run as soon as we have the slow typing feature there

Also available in: Atom PDF