action #107026
closed
coordination #109668: [saga][epic] Stable and updated non-qemu backends for SLE validation
coordination #100688: [epic][virtualization][3rd party hypervisor] Add svirt backend compatibility for vmware 7.0
Improve existing unit tests for VNC module to increase its test coverage (before doing any actual changes) size:M
Added by okurz almost 3 years ago.
Updated over 2 years ago.
Category:
Feature requests
Description
Motivation¶
To be able to safely extend VNC which we plan for VMWare 7.0 support we need to cover consoles::VNC better with our test coverage
Acceptance criteria¶
- AC1: 100% reported statement coverage for consoles::VNC in our CI tests
- AC2: VNC protocol can be tested without sockets
Suggestions¶
Related issues
1 (1 open — 0 closed)
- Tracker changed from coordination to action
- Priority changed from Normal to Low
- Status changed from New to Workable
We already estimated this ticket
- Related to action #76813: [tools] Test using svirt backend fails with auto_review:"Error connecting to VNC server.*: IO::Socket::INET: connect: Connection refused" added
- Priority changed from Low to High
- Status changed from Workable to In Progress
- Due date set to 2022-05-19
Setting due date based on mean cycle time of SUSE QE Tools
Last PR which should bring it to 100 %: https://github.com/os-autoinst/os-autoinst/pull/2051
(Not considering some other files and the C++ code. But we likely don't need to touch that and it is therefore out of scope.)
Split consoles::VNC into protocol and socket modules so that protocol is separated from networking in os-autoinst consoles::VNC
Note that I didn't follow that suggestion because for the sake of writing unit tests the current approach of mocking is sufficient. Since it is Perl any everything is dynamically typed we can always allow passing a different type of "socket object" instead of a real socket (e.g. some object which will forward stuff via web sockets).
- Due date deleted (
2022-05-19)
- Status changed from In Progress to Resolved
Also available in: Atom
PDF