https://progress.opensuse.org/https://progress.opensuse.org/themes/openSUSE/favicon/favicon.ico?15829177842022-02-17T14:36:00ZopenSUSE Project Management ToolopenQA Project - action #107026: Improve existing unit tests for VNC module to increase its test coverage (before doing any actual changes) size:Mhttps://progress.opensuse.org/issues/107026?journal_id=4923852022-02-17T14:36:00Zokurzokurz@suse.com
<ul><li><strong>Tracker</strong> changed from <i>coordination</i> to <i>action</i></li></ul> openQA Project - action #107026: Improve existing unit tests for VNC module to increase its test coverage (before doing any actual changes) size:Mhttps://progress.opensuse.org/issues/107026?journal_id=4924602022-02-17T16:35:40Zokurzokurz@suse.com
<ul><li><strong>Priority</strong> changed from <i>Normal</i> to <i>Low</i></li></ul> openQA Project - action #107026: Improve existing unit tests for VNC module to increase its test coverage (before doing any actual changes) size:Mhttps://progress.opensuse.org/issues/107026?journal_id=4930362022-02-20T16:49:02Zkraihsebastian.riedel@suse.com
<ul></ul><p>For some broader context, this document from the Python community explains pretty well why protocol implementations and I/O should be separated. <a href="https://sans-io.readthedocs.io/how-to-sans-io.html" class="external">https://sans-io.readthedocs.io/how-to-sans-io.html</a></p>
openQA Project - action #107026: Improve existing unit tests for VNC module to increase its test coverage (before doing any actual changes) size:Mhttps://progress.opensuse.org/issues/107026?journal_id=4988862022-03-09T09:20:43Zokurzokurz@suse.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Workable</i></li></ul><p>We already estimated this ticket</p>
openQA Project - action #107026: Improve existing unit tests for VNC module to increase its test coverage (before doing any actual changes) size:Mhttps://progress.opensuse.org/issues/107026?journal_id=5157282022-05-04T08:57:08Zlivdywanliv.dywan@suse.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-4 status-1 priority-4 priority-default child" href="/issues/76813">action #76813</a>: [tools] Test using svirt backend fails with auto_review:"Error connecting to VNC server.*: IO::Socket::INET: connect: Connection refused"</i> added</li></ul> openQA Project - action #107026: Improve existing unit tests for VNC module to increase its test coverage (before doing any actual changes) size:Mhttps://progress.opensuse.org/issues/107026?journal_id=5157522022-05-04T09:09:44Zokurzokurz@suse.com
<ul><li><strong>Priority</strong> changed from <i>Low</i> to <i>High</i></li></ul><p>This is becoming more important for <a class="issue tracker-4 status-3 priority-5 priority-high3 closed child" title="action: [tools][qem] Incomplete test runs on s390x with auto_review:"backend died: Error connecting to VN... (Resolved)" href="https://progress.opensuse.org/issues/99345">#99345</a> and <a class="issue tracker-4 status-1 priority-4 priority-default child" title="action: [tools] Test using svirt backend fails with auto_review:"Error connecting to VNC server.*: IO::So... (New)" href="https://progress.opensuse.org/issues/76813">#76813</a></p>
openQA Project - action #107026: Improve existing unit tests for VNC module to increase its test coverage (before doing any actual changes) size:Mhttps://progress.opensuse.org/issues/107026?journal_id=5159772022-05-04T15:44:06Zmkittlermarius.kittler@suse.com
<ul><li><strong>Assignee</strong> set to <i>mkittler</i></li></ul> openQA Project - action #107026: Improve existing unit tests for VNC module to increase its test coverage (before doing any actual changes) size:Mhttps://progress.opensuse.org/issues/107026?journal_id=5159802022-05-04T16:25:38Zmkittlermarius.kittler@suse.com
<ul><li><strong>Status</strong> changed from <i>Workable</i> to <i>In Progress</i></li></ul><p>First PR: <a href="https://github.com/os-autoinst/os-autoinst/pull/2047" class="external">https://github.com/os-autoinst/os-autoinst/pull/2047</a></p>
openQA Project - action #107026: Improve existing unit tests for VNC module to increase its test coverage (before doing any actual changes) size:Mhttps://progress.opensuse.org/issues/107026?journal_id=5160192022-05-05T04:26:19Zopenqa_reviewopenqa-review@suse.de
<ul><li><strong>Due date</strong> set to <i>2022-05-19</i></li></ul><p>Setting due date based on mean cycle time of SUSE QE Tools</p>
openQA Project - action #107026: Improve existing unit tests for VNC module to increase its test coverage (before doing any actual changes) size:Mhttps://progress.opensuse.org/issues/107026?journal_id=5163552022-05-05T16:29:55Zmkittlermarius.kittler@suse.com
<ul></ul><p>First PR merged, second PR: <a href="https://github.com/os-autoinst/os-autoinst/pull/2049" class="external">https://github.com/os-autoinst/os-autoinst/pull/2049</a></p>
openQA Project - action #107026: Improve existing unit tests for VNC module to increase its test coverage (before doing any actual changes) size:Mhttps://progress.opensuse.org/issues/107026?journal_id=5176122022-05-10T13:58:52Zokurzokurz@suse.com
<ul></ul><p>merged. <a href="https://app.codecov.io/gh/os-autoinst/os-autoinst/blob/master/consoles/VNC.pm" class="external">https://app.codecov.io/gh/os-autoinst/os-autoinst/blob/master/consoles/VNC.pm</a> shows 87.56%, looking good, looking good :)</p>
openQA Project - action #107026: Improve existing unit tests for VNC module to increase its test coverage (before doing any actual changes) size:Mhttps://progress.opensuse.org/issues/107026?journal_id=5182212022-05-11T13:37:58Zmkittlermarius.kittler@suse.com
<ul></ul><p>Last PR which should bring it to 100 %: <a href="https://github.com/os-autoinst/os-autoinst/pull/2051" class="external">https://github.com/os-autoinst/os-autoinst/pull/2051</a></p>
<p>(Not considering some other files and the C++ code. But we likely don't need to touch that and it is therefore out of scope.)</p>
<hr>
<blockquote>
<p>Split consoles::VNC into protocol and socket modules so that protocol is separated from networking in os-autoinst consoles::VNC</p>
</blockquote>
<p>Note that I didn't follow that suggestion because for the sake of writing unit tests the current approach of mocking is sufficient. Since it is Perl any everything is dynamically typed we can always allow passing a different type of "socket object" instead of a real socket (e.g. some object which will forward stuff via web sockets).</p>
openQA Project - action #107026: Improve existing unit tests for VNC module to increase its test coverage (before doing any actual changes) size:Mhttps://progress.opensuse.org/issues/107026?journal_id=5182662022-05-11T15:13:32Zokurzokurz@suse.com
<ul><li><strong>Due date</strong> deleted (<del><i>2022-05-19</i></del>)</li><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Correct approach, I would say :)</p>
<p><a href="https://github.com/os-autoinst/os-autoinst/pull/2051" class="external">https://github.com/os-autoinst/os-autoinst/pull/2051</a> is merged and provides 100% statement coverage which I think is great and also covers both ACs so let's resolve, shall we?</p>
openQA Project - action #107026: Improve existing unit tests for VNC module to increase its test coverage (before doing any actual changes) size:Mhttps://progress.opensuse.org/issues/107026?journal_id=5182692022-05-11T15:15:54Zmkittlermarius.kittler@suse.com
<ul></ul><p>AC1 is now fulfilled (<a href="https://app.codecov.io/gh/os-autoinst/os-autoinst/blob/master/consoles/VNC.pm" class="external">https://app.codecov.io/gh/os-autoinst/os-autoinst/blob/master/consoles/VNC.pm</a> is at 100 %) as well as AC2 (unit tests mock the socket).</p>
openQA Project - action #107026: Improve existing unit tests for VNC module to increase its test coverage (before doing any actual changes) size:Mhttps://progress.opensuse.org/issues/107026?journal_id=5231422022-05-25T22:31:36ZAdamWill
<ul></ul><p>The 'update framebuffer' test added here does not work properly on big-endian (or maybe the test works properly and the code is bad? Either way, there's a problem). <a href="https://progress.opensuse.org/issues/111608" class="external">https://progress.opensuse.org/issues/111608</a></p>