Project

General

Profile

Actions

action #59394

open

[qe-core][functional] Overwrite empty ISO variable everywhere where not needed, i.e. `+ISO=`, to prevent useless ISO downloading and storage

Added by okurz over 4 years ago. Updated 28 days ago.

Status:
Blocked
Priority:
Normal
Assignee:
-
Category:
Enhancement to existing tests
Target version:
-
Start date:
2019-11-13
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

Motivation

By default we pass "ISO" to all jobs even when it is not needed, e.g. in downstream jobs booting HDD. This causes useless downloads to the worker for each job as well as on each cloning. See #33946 for details. This can be prevented with a simple +ISO= in all test suites that do not actually need the ISO.

Suggestions

  • Add +ISO= to all test suites booting HDD images and not relying on the ISO
  • Crosscheck test results

Related issues 3 (1 open2 closed)

Related to openQA Project - action #38807: API call that allows to search for test settings was - Make sure all used assets are accounted for in tests on osd (#38804) New2018-07-25

Actions
Related to openQA Project - action #64938: '+ISO=' in test suite breaks a number of testsResolvedokurz2020-03-27

Actions
Copied from openQA Project - action #33946: Iso image of Parent Job is downloaded even if "--skip-deps" property is specified while cloning Child JobResolvedokurz2018-03-282019-11-12

Actions
Actions #1

Updated by okurz over 4 years ago

  • Copied from action #33946: Iso image of Parent Job is downloaded even if "--skip-deps" property is specified while cloning Child Job added
Actions #2

Updated by okurz over 4 years ago

  • Related to action #38807: API call that allows to search for test settings was - Make sure all used assets are accounted for in tests on osd (#38804) added
Actions #3

Updated by okurz over 4 years ago

  • Status changed from New to In Progress
  • Assignee set to okurz

doing it on o3

Actions #4

Updated by okurz over 4 years ago

  • Status changed from In Progress to Workable
  • Assignee deleted (okurz)

ok, only hadded +ISO= to "boot_to_snapshot" as I have tested this scenario. https://openqa.opensuse.org/admin/test_suites shows 337 test suites mentionting "HDD_1=". Some need the ISO, e.g. "external_iso". For the most I am not sure if the ISO is not enabled as repo and used during install so I will leave this for now. I recommend to check the scenarios if the ISO is actually enabled and then just switch all, e.g. using API or DB update.

Actions #5

Updated by mgriessmeier over 4 years ago

  • Subject changed from Overwrite empty ISO variable everywhere where not needed, i.e. `+ISO=`, to prevent useless ISO downloading and storage to [functional][u][y] Overwrite empty ISO variable everywhere where not needed, i.e. `+ISO=`, to prevent useless ISO downloading and storage
Actions #6

Updated by riafarov over 4 years ago

  • Subject changed from [functional][u][y] Overwrite empty ISO variable everywhere where not needed, i.e. `+ISO=`, to prevent useless ISO downloading and storage to [functional][u] Overwrite empty ISO variable everywhere where not needed, i.e. `+ISO=`, to prevent useless ISO downloading and storage

I'm not sure if that's the right solution. If iso gets removed, we won't be able to regenerate the image, so having setting will help us. On the worker side, copying definitely can be improved by not doing so if we boot into the image and iso is not used as a repo (like in the case of repoless installer). So we are not going to change test suites in our job group in order to have chance to re-generate images.

Actions #7

Updated by okurz over 4 years ago

riafarov wrote:

I'm not sure if that's the right solution. If iso gets removed, we won't be able to regenerate the image, so having setting will help us.

There should still be the ISO variable for all jobs that rely on the ISO, e.g. create_hdd_…. I don't think having the ISO referenced in more tests ensures that the image would stay around longer effectively.

Actions #8

Updated by ggardet_arm about 4 years ago

  • Related to action #64938: '+ISO=' in test suite breaks a number of tests added
Actions #9

Updated by tjyrinki_suse over 3 years ago

  • Subject changed from [functional][u] Overwrite empty ISO variable everywhere where not needed, i.e. `+ISO=`, to prevent useless ISO downloading and storage to [qe-core][functional] Overwrite empty ISO variable everywhere where not needed, i.e. `+ISO=`, to prevent useless ISO downloading and storage
Actions #10

Updated by szarate almost 3 years ago

  • Status changed from Workable to Blocked

Lot of busy work, setting to blocked until api call in #38807 is provided

Actions #11

Updated by slo-gin over 1 year ago

This ticket was set to Normal priority but was not updated within the SLO period. Please consider picking up this ticket or just set the ticket to the next lower priority.

Actions #12

Updated by slo-gin 28 days ago

This ticket was set to Normal priority but was not updated within the SLO period. Please consider picking up this ticket or just set the ticket to the next lower priority.

Actions

Also available in: Atom PDF