Project

General

Profile

action #59394

[qe-core][functional] Overwrite empty ISO variable everywhere where not needed, i.e. `+ISO=`, to prevent useless ISO downloading and storage

Added by okurz about 2 years ago. Updated 8 months ago.

Status:
Blocked
Priority:
Normal
Assignee:
-
Category:
Enhancement to existing tests
Target version:
-
Start date:
2019-11-13
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

Motivation

By default we pass "ISO" to all jobs even when it is not needed, e.g. in downstream jobs booting HDD. This causes useless downloads to the worker for each job as well as on each cloning. See #33946 for details. This can be prevented with a simple +ISO= in all test suites that do not actually need the ISO.

Suggestions

  • Add +ISO= to all test suites booting HDD images and not relying on the ISO
  • Crosscheck test results

Related issues

Related to openQA Project - action #38807: Make sure all used assets are accounted for in tests on osd (#38804) but not as assets which people need to download on cloning the job as the ISO is not actually usedNew2018-07-25

Related to openQA Project - action #64938: '+ISO=' in test suite breaks a number of testsResolved2020-03-27

Copied from openQA Project - action #33946: Iso image of Parent Job is downloaded even if "--skip-deps" property is specified while cloning Child JobResolved2018-03-282019-11-12

History

#1 Updated by okurz about 2 years ago

  • Copied from action #33946: Iso image of Parent Job is downloaded even if "--skip-deps" property is specified while cloning Child Job added

#2 Updated by okurz about 2 years ago

  • Related to action #38807: Make sure all used assets are accounted for in tests on osd (#38804) but not as assets which people need to download on cloning the job as the ISO is not actually used added

#3 Updated by okurz about 2 years ago

  • Status changed from New to In Progress
  • Assignee set to okurz

doing it on o3

#4 Updated by okurz about 2 years ago

  • Status changed from In Progress to Workable
  • Assignee deleted (okurz)

ok, only hadded +ISO= to "boot_to_snapshot" as I have tested this scenario. https://openqa.opensuse.org/admin/test_suites shows 337 test suites mentionting "HDD_1=". Some need the ISO, e.g. "external_iso". For the most I am not sure if the ISO is not enabled as repo and used during install so I will leave this for now. I recommend to check the scenarios if the ISO is actually enabled and then just switch all, e.g. using API or DB update.

#5 Updated by mgriessmeier almost 2 years ago

  • Subject changed from Overwrite empty ISO variable everywhere where not needed, i.e. `+ISO=`, to prevent useless ISO downloading and storage to [functional][u][y] Overwrite empty ISO variable everywhere where not needed, i.e. `+ISO=`, to prevent useless ISO downloading and storage

#6 Updated by riafarov almost 2 years ago

  • Subject changed from [functional][u][y] Overwrite empty ISO variable everywhere where not needed, i.e. `+ISO=`, to prevent useless ISO downloading and storage to [functional][u] Overwrite empty ISO variable everywhere where not needed, i.e. `+ISO=`, to prevent useless ISO downloading and storage

I'm not sure if that's the right solution. If iso gets removed, we won't be able to regenerate the image, so having setting will help us. On the worker side, copying definitely can be improved by not doing so if we boot into the image and iso is not used as a repo (like in the case of repoless installer). So we are not going to change test suites in our job group in order to have chance to re-generate images.

#7 Updated by okurz almost 2 years ago

riafarov wrote:

I'm not sure if that's the right solution. If iso gets removed, we won't be able to regenerate the image, so having setting will help us.

There should still be the ISO variable for all jobs that rely on the ISO, e.g. create_hdd_…. I don't think having the ISO referenced in more tests ensures that the image would stay around longer effectively.

#8 Updated by ggardet_arm over 1 year ago

  • Related to action #64938: '+ISO=' in test suite breaks a number of tests added

#9 Updated by tjyrinki_suse about 1 year ago

  • Subject changed from [functional][u] Overwrite empty ISO variable everywhere where not needed, i.e. `+ISO=`, to prevent useless ISO downloading and storage to [qe-core][functional] Overwrite empty ISO variable everywhere where not needed, i.e. `+ISO=`, to prevent useless ISO downloading and storage

#10 Updated by szarate 8 months ago

  • Status changed from Workable to Blocked

Lot of busy work, setting to blocked until api call in #38807 is provided

Also available in: Atom PDF