Project

General

Profile

Actions

action #49547

open

[virtualization][svirt] Refactor how svirt handles credentials for SSH

Added by pvorel almost 6 years ago. Updated about 4 years ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
Feature requests
Target version:
Start date:
2019-03-21
Due date:
% Done:

0%

Estimated time:

Description

Handling variables for credentials in svirt deserve cleanup.
Svirt uses SSH for connecting to VM host (VIRSH_HOSTNAME) or intermediary which handles VNC (VIRSH_GUEST).

Using serial console uses method read_credentials_from_virsh_variables(), but it's not obvious from it's name that it's currently just for them. If they're selected by according to whether used for connecting to VM host or intermediary it'd be possible to
use it for run_ssh_cmd() as well (and remove duplicity in load_snapshot()).

+ HYPERV_SERVER looks like duplicity with VIRSH_HOSTNAME decide, whether delete it.

Found, when working on #45863


Related issues 1 (0 open1 closed)

Related to openQA Project (public) - action #45863: [s390x][svirt][ltp] Fix serial terminal console implementation for svirt backend and use it's outputResolvedpvorel

Actions
Actions

Also available in: Atom PDF