Project

General

Profile

action #45863

[s390x][svirt][ltp] Fix serial terminal console implementation for svirt backend and use it's output

Added by pvorel over 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
SUSE QA tests - Done - kernel&network
Start date:
Due date:
% Done:

0%

Estimated time:
Difficulty:
Duration:

Description

#36457 implemented generic serial console for svirt backend (serial0.txt in assets). But that's not enough LTP tests s390x as tests itself still have output in bitmap (https://openqa.suse.de/tests/2336735#step/ping601/1) instead of text (https://openqa.suse.de/tests/2337315#step/ping601/6).

The goal is to have text output in serial_terminal.txt also on svirt when using select_serial_terminal().


Related issues

Related to openQA Project - action #36457: Implement serial terminal console for svirt backendResolved2018-05-23

Related to openQA Project - action #46967: [functional][u][tools] warning in bootloader_zkvm: Calling Net::SSH2::Channel::readline in non-blocking mode is usually a programming errorResolved2019-02-01

Related to openQA Project - action #49394: [s390x][svirt] Print content of kernel log and serial console into "Serial output" fieldNew2019-03-15

Related to openQA Project - action #49547: [virtualization][svirt] Refactor how svirt handles credentials for SSHNew2019-03-21

Related to openQA Project - action #50945: [tools][svirt] Svirt serial backend gets stalled by new lines in command passed to script_runNew2019-04-30

History

#1 Updated by pvorel over 1 year ago

  • Related to action #36457: Implement serial terminal console for svirt backend added

#2 Updated by pvorel over 1 year ago

  • Status changed from New to In Progress

WIP, adding new serial console for svirt backend (not only s390x).

#3 Updated by pvorel over 1 year ago

Virtio terminal (consoles::virtio_terminal) uses unix socket as file handle.

Serial console for svirt (consoles::sshVirtshSUT) implementation, which connects over SSH (with Net::SSH2) provides network socket IO::Socket::IP, which cannot used the same way as unix socket :). This part needs to be rewritten.

#4 Updated by pvorel over 1 year ago

Created 2 PR:

https://github.com/os-autoinst/os-autoinst/pull/1109
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6841

But still the main thing (support for network sockets in consoles::virtio_screen) I haven't implemented yet.

#5 Updated by pvorel over 1 year ago

PoC of my special test:
http://quasar.suse.cz/tests/1892#downloads
http://quasar.suse.cz/tests/1892/file/serial_terminal.txt

Testing also real test (install_ltp):
http://quasar.suse.cz/tests/1896

Original PR enhanced, needs cleanup + support of live streaming of serial_terminal.txt
https://github.com/os-autoinst/os-autoinst/pull/1109

Also worker required tiny change:
https://github.com/os-autoinst/openQA/pull/2003

Test side finished, but will need to wait for merge and deployment of other two:
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6841

#6 Updated by pvorel over 1 year ago

  • Subject changed from [s390x][svirt][ltp] Use output of serial console on svirt to [s390x][svirt][ltp] Fix serial terminal console for svirt backend and use it's output

#7 Updated by pvorel over 1 year ago

  • Subject changed from [s390x][svirt][ltp] Fix serial terminal console for svirt backend and use it's output to [s390x][svirt][ltp] Fix serial terminal console implementation for svirt backend and use it's output

#8 Updated by pvorel over 1 year ago

  • Related to action #46967: [functional][u][tools] warning in bootloader_zkvm: Calling Net::SSH2::Channel::readline in non-blocking mode is usually a programming error added

#9 Updated by pvorel over 1 year ago

Updated PRs, waiting for feedback.
https://github.com/os-autoinst/os-autoinst/pull/1109
https://github.com/os-autoinst/openQA/pull/2003
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6841

Travis test is failing due download issue (see https://api.travis-ci.org/v3/job/505131336/log.txt):

Fetching http://no.where/authors/id/D/DS/DSKOLL/IO-stringy-2.111.tar.gz ... FAIL

#10 Updated by pvorel over 1 year ago

  • Related to action #49394: [s390x][svirt] Print content of kernel log and serial console into "Serial output" field added

#11 Updated by pvorel over 1 year ago

  • Status changed from In Progress to Feedback

Waiting for mnowak review and approval.

#12 Updated by pvorel over 1 year ago

  • Related to action #49547: [virtualization][svirt] Refactor how svirt handles credentials for SSH added

#13 Updated by pvorel over 1 year ago

  • Status changed from Feedback to In Progress

openQA PR merged.
https://github.com/os-autoinst/openQA/pull/2003

Test repository ready (but going to be merged once os-autoinst is deployed)
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6841

Still having some issues with os-autoinst, but close to have it all fixed.
https://github.com/os-autoinst/os-autoinst/pull/1109
I got into trap with cleaning way too much, so handling issue with Hyper-V and VMware (tests maintained by mnowak). I guess I've found problematic parts and reverted them and document them (#49547).

Now testing it + need to solve issue with install_ltp.

#14 Updated by pvorel over 1 year ago

  • Status changed from In Progress to Feedback

#15 Updated by pvorel over 1 year ago

Waiting for mkittler to merge https://github.com/os-autoinst/os-autoinst/pull/1109

Test waits to be merged once os-autoinst is merged and deployed
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6841

#16 Updated by pcervinka over 1 year ago

  • Blocks action #49655: [qam][sporadic][blue] test fails in evolution_prepare_servers - Race condition when typing password added

#17 Updated by pvorel about 1 year ago

os-autoinst part (the biggest one, https://github.com/os-autoinst/os-autoinst/pull/1109) merged.

Before merging test part (https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6841) waiting 1) for being deployed 2) set SERIAL_CONSOLE=0 to all but s390x svirt machines in their definitions (so it's enabled only for s390x).

#18 Updated by pcervinka about 1 year ago

  • Blocks deleted (action #49655: [qam][sporadic][blue] test fails in evolution_prepare_servers - Race condition when typing password)

#19 Updated by pvorel about 1 year ago

  • Related to action #50945: [tools][svirt] Svirt serial backend gets stalled by new lines in command passed to script_run added

#20 Updated by pvorel about 1 year ago

Agreed with mnowak to wait for SLE15 SP1 GMC before merging changes in test repository (last piece)
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6841

#21 Updated by pvorel about 1 year ago

  • Status changed from Feedback to Resolved

Test changes were finally today (after GM) merged.
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6841

#22 Updated by jlausuch about 1 year ago

  • Target version changed from Current Sprint - kernel to Done - kernel&network

Also available in: Atom PDF