action #35760
closedcoordination #34138: [functional][u][epic][eternal] work on any issue from http://github.com/os-autoinst/openqa_review/issues/
[functional][u][medium] work on any issue from http://github.com/okurz/openqa_review/issues/
Added by okurz almost 6 years ago. Updated almost 6 years ago.
0%
Description
Acceptance criteria¶
- AC1: at least one issue from openqa-review is resolved by [u]-team
Tasks¶
T1: * work on https://github.com/okurz/openqa_review/issues/85
T2: * work on https://github.com/okurz/openqa_review/issues/78
T3: * Refactor the openqa-review code to not use "Issue" object for the messages that does not have a valid bugref.
useful links¶
Updated by okurz almost 6 years ago
- Copied from action #35758: [functional][y][medium] Handle "boo#0" not as error in log but better in openqa_review added
Updated by SLindoMansilla almost 6 years ago
- Due date changed from 2018-06-05 to 2018-06-19
Please look for a specific issue so we can estimate properly
Updated by okurz almost 6 years ago
- Due date changed from 2018-06-19 to 2018-06-05
You, I do not want to spoon-feed you. I am open for you to pick up any issue but if you really can not decide on your own, pick https://github.com/okurz/openqa_review/issues/85 which I saw multiple times recently in the daily generated reports.
Updated by mgriessmeier almost 6 years ago
- Due date changed from 2018-06-05 to 2018-06-19
Updated by mgriessmeier almost 6 years ago
- Subject changed from [functional][u] work on any issue from http://github.com/okurz/openqa_review/issues/ to [functional][u][medium] work on any issue from http://github.com/okurz/openqa_review/issues/
- Description updated (diff)
Updated by oorlov almost 6 years ago
- Status changed from Workable to In Progress
Updated by okurz almost 6 years ago
- Target version changed from Milestone 16 to Milestone 17
Updated by oorlov almost 6 years ago
I've added PR, that fixes issue#76
Waiting for review.
Updated by oorlov almost 6 years ago
- Status changed from In Progress to Feedback
Updated by oorlov almost 6 years ago
- Description updated (diff)
Added PR for the Issue#78: https://github.com/okurz/openqa_review/pull/88
Updated by oorlov almost 6 years ago
My latest changes caused an issue when openqa_report with 'query_issue_status' parameter was executed against openQA issue with invalid bugref. bugid was not initialized and it caused AttributeError while calling 'self.bugid == 0' in 'Issue' object initialization.
I've fixed this with PR: https://github.com/okurz/openqa_review/pull/89
I'll keep this ticket in 'Feedback' for a while, just to be sure that all the cases covered and new issues are not appear.
Updated by oorlov almost 6 years ago
Observation: When openQA issue does not have a valid bugref, it is added as 'product' issue. Reminder comment script goes through the 'product' issues and looks for a last comment. It will fail on assertion if issue type is not 'bugzilla'.
Fix: https://github.com/okurz/openqa_review/pull/92
The commit resolves the issue by skipping 'product' issues with invalid issue type.
Updated by okurz almost 6 years ago
- Target version changed from Milestone 17 to Milestone 17
Updated by mgriessmeier almost 6 years ago
PR is merged - can we resolve it? @oorlov?
Updated by oorlov almost 6 years ago
- Description updated (diff)
- Status changed from Feedback to In Progress
I want to continue working on this ticket, on T3.
Updated by mgriessmeier almost 6 years ago
- Due date changed from 2018-06-19 to 2018-07-03
Updated by mgriessmeier almost 6 years ago
- Due date changed from 2018-07-03 to 2018-07-31
Updated by oorlov almost 6 years ago
I did not have enough time during the sprint to look at this ticket.
Updated by okurz almost 6 years ago
Do you still plan to go further or should we close this ticket by now?
Updated by okurz almost 6 years ago
- Target version changed from Milestone 17 to Milestone 18
Updated by oorlov almost 6 years ago
- Status changed from In Progress to Feedback
Added ability to parse urls in soft-fail messages.
PR: https://github.com/okurz/openqa_review/pull/103
Regarding T3, after deeper investigation, I've came to conclusion that it is pretty hard to refactor current app to avoid using the Issue object just in case if there is no valid bugref in soft-fail message. The code was designed to use it everywhere. So, the time that I'll spend on this does not correlate with the benefit of the refactoring, in my opinion.
I'm suggesting to postpone it or even to just leave it as is until we'll not face real need in refactoring that.
Updated by mgriessmeier almost 6 years ago
oorlov wrote:
Added ability to parse urls in soft-fail messages.
PR: https://github.com/okurz/openqa_review/pull/103
Regarding T3, after deeper investigation, I've came to conclusion that it is pretty hard to refactor current app to avoid using the Issue object just in case if there is no valid bugref in soft-fail message. The code was designed to use it everywhere. So, the time that I'll spend on this does not correlate with the benefit of the refactoring, in my opinion.
I'm suggesting to postpone it or even to just leave it as is until we'll not face real need in refactoring that.
yup, please create a followup ticket for this refactoring task and resolve this one
Updated by oorlov almost 6 years ago
- Related to action #38957: [functional] Refactor the openqa-review code to not use "Issue" object for the messages that does not have a valid bugref. added