Project

General

Profile

action #20464

[scheduling] Job created with "jobs post" not expand specified MACHINE variable

Added by asmorodskyi almost 3 years ago. Updated 12 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Feature requests
Target version:
Start date:
2017-07-14
Due date:
% Done:

100%

Estimated time:
Difficulty:
medium
Duration:

Description

I am creating job with "jobs post" and specifying this set of variables :
{ "HDDSIZEGB=20",
"MACHINE=aarch64",
"VERSION=12-SP2",
"FLAVOR=Server-HPC",
"DISTRI=sle",
"WORKER_CLASS=qemu_aarch64",
"DESKTOP=textmode",
"ARCH=aarch64",
"PACKAGE_REPO=http://download.suse.de/ibs/Devel:/HPC:/SLE12SP2/standard",
"PACKAGETOINSTALL=openqa-ci-test-fail-openqa-tests",
"_GROUP=HPC StagingNext",
"HDD_1=sle-12-SP2-Server-HPC-aarch64-0290-with-hpc.qcow2",
"TEST=single_package_openqa-ci-test-fail-openqa-tests",
"HPC=1",
"BUILD=01"}

Created jobs don't get all variables which assigned to MACHINE='aarch64' in openQA settings.


Related issues

Has duplicate openQA Project - action #51479: Some jobs don't get all the %variables% properly expandedRejected2019-05-15

History

#1 Updated by szarate almost 3 years ago

WHile talking to asmorodskyi about this issue in particular, I was thinking that maybe if %MACHINE is found, it could be expanded by the webUI like we do already with other variables...

#2 Updated by coolo almost 3 years ago

both the expansion and the MACHINE is a feature of the job templates - which is only used by isos post. clone job also posts jobs with MACHINE because the other instance has it - and I don't think the MACHINE on your instance should have any relevance for clone_job.

So I would go with _MACHINE, _TEST_SUITE and _PRODUCT - along with _GROUP

#3 Updated by asmorodskyi almost 3 years ago

usage of _MACHINE variable produce same behavior . Or requirement is in obligatory usage of all 3 ( _MACHINE / _TEST_SUITE and _PRODUCT ) ?

#4 Updated by coolo almost 3 years ago

This is not supported yet - but it sounds useful to support, so we duplicate less infos

#5 Updated by coolo over 2 years ago

  • Subject changed from [tools] Job created with "jobs post" not expand specified MACHINE variable to Job created with "jobs post" not expand specified MACHINE variable
  • Category set to 122
  • Target version set to Ready

#6 Updated by coolo over 1 year ago

  • Assignee set to Xiaojing_liu
  • Target version changed from Ready to Current Sprint
  • Difficulty set to medium

#7 Updated by Xiaojing_liu about 1 year ago

  • Status changed from New to In Progress

#8 Updated by Xiaojing_liu about 1 year ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

#9 Updated by mkittler about 1 year ago

  • Status changed from Resolved to In Progress

The implementation needs to be revised, see https://github.com/os-autoinst/openQA/pull/2073.

Likely it makes most sense to cherry-pick your first commit https://github.com/os-autoinst/openQA/pull/2057/commits/9091529a8d0e8c6b62ff38a503f1a7502a2ec62c and improve it as needed:

  • The code for the settings expansion should be correct. That is the most important point and it can be verified with the testcases you created today. As kraih mentioned it makes also sense to add tests with variables used in production.
  • It should be in its own module because the utils have already grown too big. But I still wouldn't use object orientation here. It is simply an overkill in my opinion. Without object orientation the module can still hide the internal helper.
  • Prevent unnecessary copies. (The previous implementation attempt created an unnecessary copy in the constructor.)

#10 Updated by szarate about 1 year ago

  • Related to action #51479: Some jobs don't get all the %variables% properly expanded added

#11 Updated by szarate about 1 year ago

  • Related to deleted (action #51479: Some jobs don't get all the %variables% properly expanded)

#12 Updated by szarate about 1 year ago

  • Has duplicate action #51479: Some jobs don't get all the %variables% properly expanded added

#14 Updated by okurz about 1 year ago

  • Subject changed from Job created with "jobs post" not expand specified MACHINE variable to [scheduling] Job created with "jobs post" not expand specified MACHINE variable
  • Category changed from 122 to Feature requests

#15 Updated by Xiaojing_liu 12 months ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF