action #124347
closed[sles][15-sp5][Build70.1][qe-core] Wrong product selected and failed to match needle
0%
Description
Observation¶
Start with Build70.1, wrong product selected and failed to match needle, for example, sap selected but sles wanted
Last good build, for example, good one with Build67.1
Steps to reproduce¶
- Run 15-SP5 Online fresh installation on bare-metal machine
- Wait for "welcome" step to finish
Impact¶
All test run failed with 15-SP5 Online fresh installation
Problem¶
Key combination "alt-i" does not select SLES product anymore which needs to be selected by using "alt-s". "alt-i" now selects sap product.
Suggestion¶
- Check whether a rightful change to product
- Needs to change code if how to select product is going to be changed this way.
Workaround¶
n/a
Updated by xlai almost 2 years ago
- Status changed from New to Workable
- Priority changed from Normal to Immediate
Updated by waynechen55 almost 2 years ago
There is bugzilla ticket as well:https://bugzilla.suse.com/show_bug.cgi?id=1208175
Updated by waynechen55 almost 2 years ago
It seems that this issues happens to:
virtualization https://openqa.suse.de/tests/10480968#step/welcome/6
Performance http://openqa.qa2.suse.asia/tests/55267#step/welcome/6
Security https://openqa.suse.de/tests/10466777#step/welcome/6
It looks like a general problem. Could any expert on this can help have a look ?
Updated by okurz almost 2 years ago
Problem¶
Key combination "alt-i" does not select SLES product anymore which needs to be selected by using "alt-s". "alt-i" now selects sap product.
Then either update the hotkeys based on the new version or use send_key_until_needlematch
with the down-key.
By the way, you have added keywords in the subject [sles][15-sp5][needle]
but no team-assignment so it is likely that no ticket will immediately look into this.
Updated by waynechen55 almost 2 years ago
- Subject changed from [sles][15-sp5][needle] Wrong product selected and failed to match needle to [sles][15-sp5][Build70.1] Wrong product selected and failed to match needle
Updated by szarate almost 2 years ago
- Tags set to bugbusters
- Category set to Bugs in existing tests
- Status changed from Workable to In Progress
- Assignee set to szarate
Trying out:
openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/16366 https://openqa.suse.de/tests/10478712
Created job #10483482: sle-15-SP5-Online-x86_64-Build70.1-gi-guest_developing-on-host_developing-xen@64bit-ipmi-large-mem-intel -> https://openqa.suse.de/t10483482
Created job #10483534: sle-15-SP5-Online-ppc64le-Build70.1-create_hdd_textmode@ppc64le-spvm -> https://openqa.suse.de/t10483534
Updated by szarate almost 2 years ago
My fear is that we will have to update all of the shortcuts, and well... the old style of installation must be sunset.
Updated by JERiveraMoya almost 2 years ago
szarate wrote:
My fear is that we will have to update all of the shortcuts, and well... the old style of installation must be sunset.
Might be more simple, only online textmode installation are affected, for qt, shortcut is not used, looks like now everywhere now will be 'alt-s' (but I might have missed some place to look)
so with something like the following could work:
elsif (is_sle '15-SP1+' && is_sle '<=15-SP4') {
...
}
elsif (is_sle '<=15-SP5') {
return (sles => 's');
}
Take into account that the root cause of this is new feature of SUMA not showing for this particular product SLE 15 SP5 in the installation for product selection. For Online the bug is fixed, but we should ignore fixing this for Full, as it will be updated once https://bugzilla.suse.com/show_bug.cgi?id=1208180 is fixed.
Updated by slo-gin almost 2 years ago
This ticket was set to Immediate priority but was not updated within the SLO period. Please consider picking up this ticket or just set the ticket to the next lower priority.
Updated by waynechen55 almost 2 years ago
It seems there are two fixes for the issue ?
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/16368
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/16366
I gave them a look for a while, I can not tell which one is better and less-break-prone till now. Maybe they are equally good ?
And do we need to take https://bugzilla.suse.com/show_bug.cgi?id=1208180 into consideration ? For Full Media, the hotkey for SLES should be "u" ? To be honest, I do not know too much about this.
Updated by waynechen55 almost 2 years ago
- Tags deleted (
bugbusters) - Category deleted (
Bugs in existing tests) - Assignee deleted (
szarate)
After giving them a second look, I think might be https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/16368 is better ?
Because the most specific one should be put at the last instead at the beginning, otherwise the other general ones will be overwritten. IMHO.
Updated by waynechen55 almost 2 years ago
- Category set to Bugs in existing tests
- Assignee set to szarate
Updated by xlai almost 2 years ago
- Status changed from In Progress to Resolved
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/16368 is merged
and validation passed in OSD, see https://openqa.suse.de/tests/10493315#step/welcome/5.
@szarate I hope you won't mind. I guess so ;-) Thanks a lot for setting yourself as assignee and give the quick fix too.
Updated by szarate almost 2 years ago
- Assignee changed from szarate to rainerkoenig
No worries Alice :), we're all part of the same team
Updated by tjyrinki_suse almost 2 years ago
- Status changed from Resolved to Workable
Thanks Rainer for the fix! I wonder if this should be re-opened though as mentioned in the PR comment that create_hdd_textmode still fails and https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/16366 or more work would be needed additionally? Please re-close if there's already a followup ticket I don't find. Wayne's comment #3 already listed some of these remaining failures too.
Updated by rainerkoenig almost 2 years ago
I checked the jobs from Wayne's comment #3 and all jobs passed in "welcome.pm" after the PR was merged (see latest results).
So at the moment I consider this issue as fixed.
Updated by szarate almost 2 years ago
Added two more changes to my PR, Reverting Rainer's PR and adding a workaround for disable_grub_timeout
module
Updated by szarate almost 2 years ago
rainerkoenig wrote:
I checked the jobs from Wayne's comment #3 and all jobs passed in "welcome.pm" after the PR was merged (see latest results).
So at the moment I consider this issue as fixed.
Updated by slo-gin almost 2 years ago
This ticket was set to Immediate priority but was not updated within the SLO period. Please consider picking up this ticket or just set the ticket to the next lower priority.
Updated by pcervinka almost 2 years ago
- Related to action #124481: [sles][15-sp5][Build72.1] openQA welcome.pm send incorrect shortcut during product selection on ppc64le platform added
Updated by pcervinka almost 2 years ago
It also impacts our job group https://openqa.suse.de/tests/10504533#step/welcome/6
Updated by tjyrinki_suse almost 2 years ago
With the latest changes uefi jobs still fail regarding disable_grub_timeout, while some of the others pass.
This https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/16368 fixed the product selection, partially, but revealed https://bugzilla.suse.com/show_bug.cgi?id=1208266 later on.
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/16366 tried to fix the product selection more, and also workaround the bug, but it still fails in some of the cases.
Updated by szarate almost 2 years ago
- Sprint set to QE-Core: February Sprint (Feb 08 - Mar 08)
- Status changed from Workable to Feedback
- Assignee changed from rainerkoenig to szarate
- Target version set to QE-Core: Ready
This should fix it, thought about adding a record_soft_failure, however atm we're good enough.
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/16368
tjyrinki_suse wrote:
With the latest changes uefi jobs still fail regarding disable_grub_timeout, while some of the others pass.
This https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/16368 fixed the product selection, partially, but revealed https://bugzilla.suse.com/show_bug.cgi?id=1208266 later on.
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/16366 tried to fix the product selection more, and also workaround the bug, but it still fails in some of the cases.
Updated by szarate almost 2 years ago
- Related to action #124430: Right key doesn't reach the SUT when switching to tab Bootloader Options added
Updated by tjyrinki_suse almost 2 years ago
@foursixnine I assume you mean https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/16389 - thank you! Trying UEFI jobs now.
Updated by slo-gin almost 2 years ago
This ticket was set to Immediate priority but was not updated within the SLO period. Please consider picking up this ticket or just set the ticket to the next lower priority.
Updated by szarate almost 2 years ago
- Subject changed from [sles][15-sp5][Build70.1] Wrong product selected and failed to match needle to [sles][15-sp5][Build70.1][qe-core] Wrong product selected and failed to match needle
- Status changed from Feedback to Resolved
This is done
Updated by szarate almost 2 years ago
- Has duplicate action #124481: [sles][15-sp5][Build72.1] openQA welcome.pm send incorrect shortcut during product selection on ppc64le platform added
Updated by szarate almost 2 years ago
- Related to deleted (action #124481: [sles][15-sp5][Build72.1] openQA welcome.pm send incorrect shortcut during product selection on ppc64le platform)
Updated by szarate almost 2 years ago
- Has duplicate action #124430: Right key doesn't reach the SUT when switching to tab Bootloader Options added
Updated by szarate almost 2 years ago
Also https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/16400 which solves the last missing piece in the disable_grub_timeout on staging; https://suse.slack.com/archives/C02CANHLANP/p1676551751823679
Updated by szarate almost 2 years ago
- Related to action #124718: [qe-core][15-SP4] Test fails in scc_registration - Wrong product selected during welcome screen. added