Project

General

Profile

coordination #98457

[epic] Handle openqa-review reminder comments on very old jobs better

Added by okurz 3 months ago. Updated 12 days ago.

Status:
Workable
Priority:
Normal
Assignee:
-
Target version:
Start date:
2021-10-14
Due date:
2021-11-19
% Done:

100%

Estimated time:
(Total: 0.00 h)

Description

Motivation

openqa-review puts reminder comments jobs even they are multiple months old. This can be confusing to some users and the existing options in https://github.com/os-autoinst/openqa_review/blob/master/openqa_review/openqa_review.py#L196 might not be good enough for some users.
Also see https://suse.slack.com/archives/C02CANHLANP/p1631255003169600

Ideas

  • DONE Don't comment if the content of the comment would be the same with same job -> #100982 #101722
  • DONE Maybe just extend the reminder comment with the option to specify a label instead of a bugref, e.g. label:wontfix:bsc1234 -> https://github.com/os-autoinst/openqa_review/pull/177
  • Change the reminder comments if there are already existing reminder comments:
    1. Compare the existing reminder comments with the template. If it's the same except for $name and $url then do not repeat the steps what can be done to prevent more reminders, just the starting line and $name and $url and maybe a pointer to the previous comment
    2. If there are already two (or more?) similar reminder comments as above vary the message even more
    3. If there are more than N reminder comments write a final notice and that openqa-review gives up to remind

Discarded ideas

  • Suggestion by foursixnine: Don't comment at all on a job result that is multiple months old. okurz sees a problem with that approach because if these results are still the "most recent" ones then users might be able to follow why such jobs would not be referenced in reminder comments -> It's suggested to move according job groups to "Released" or "EOL" or simply ensure that testing starts earlier, e.g. for Alpha0 of new product iterations
  • Additional suggestions by mdoucha: Don't remind on soft-fails: "Most soft-fails in kernel groups are WONTFIX issues and stuff that isn't important enough to fix immediately. We know about it, we'll fix what needs to be fixed eventually, we don't need a reminder". This seems to be a squad specific workflow which is not generally true. So here I would stick with the current behaviour -> It's suggested to use "record_info" instead of "record_soft_failure" for such issues

Subtasks

action #100982: openqa-review: Do not post reminder comment if comment would be exactly the same as the last size:MResolvedjbaier_cz

action #101722: openqa-review: Do not post reminder comment in progress.opensuse.org if comment would be exactly the same as the last size:MResolvedtinita

History

#1 Updated by okurz 3 months ago

#2 Updated by okurz 2 months ago

  • Description updated (diff)

#3 Updated by okurz about 2 months ago

  • Description updated (diff)

#4 Updated by okurz about 2 months ago

  • Tracker changed from action to coordination
  • Subject changed from Handle openqa-review reminder comments on very old jobs better to [epic] Handle openqa-review reminder comments on very old jobs better

from estimation meeting

#5 Updated by mkittler about 2 months ago

  • Status changed from New to Workable

#6 Updated by okurz about 2 months ago

  • Description updated (diff)
  • Status changed from Workable to Blocked
  • Assignee set to okurz

added one idea how to handle multiple reminder comments with similar content and no response in tickets. Have not created a dedicated subticket for that. First we can go with the existing subtask and see how we proceed.

#7 Updated by okurz 24 days ago

  • Description updated (diff)
  • Status changed from Blocked to Workable

both subtasks finished. We can continue with the other ideas.

#8 Updated by okurz 12 days ago

  • Assignee deleted (okurz)

Also available in: Atom PDF