Project

General

Profile

action #101722

coordination #98457: [epic] Handle openqa-review reminder comments on very old jobs better

openqa-review: Do not post reminder comment in progress.opensuse.org if comment would be exactly the same as the last size:M

Added by jbaier_cz 3 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
Start date:
2021-10-14
Due date:
% Done:

0%

Estimated time:

Description

Motivation

openqa-review puts reminder comments jobs even they are multiple months old. This can be confusing to some users and the existing options in https://github.com/os-autoinst/openqa_review/blob/master/openqa_review/openqa_review.py#L196 might not be good enough for some users.
Also see https://suse.slack.com/archives/C02CANHLANP/p1631255003169600
Note that this is especially about progress.o.o and not the same as #100982.

Acceptance criteria

  • AC1: No comment in progress is posted if the content of the comment would be the same with same job

Suggestions


Related issues

Related to QA - action #102200: openqa-review pipeline failed: 'NoneType' object is not subscriptable, or failed with `assert self.issue_type == "bugzilla"` size:MResolved2021-11-102021-11-25

Copied from QA - action #100982: openqa-review: Do not post reminder comment if comment would be exactly the same as the last size:MResolved2021-10-14

History

#1 Updated by jbaier_cz 3 months ago

  • Copied from action #100982: openqa-review: Do not post reminder comment if comment would be exactly the same as the last size:M added

#2 Updated by jbaier_cz 3 months ago

  • Assignee deleted (jbaier_cz)

#3 Updated by mkittler 3 months ago

  • Due date deleted (2021-11-02)

I assume the due-date was wrongly copied from #100982.

#4 Updated by tinita 3 months ago

  • Subject changed from openqa-review: Do not post reminder comment in progress.opensuse.org if comment would be exactly the same as the last to openqa-review: Do not post reminder comment in progress.opensuse.org if comment would be exactly the same as the last size:M
  • Status changed from New to Workable

#5 Updated by tinita 3 months ago

  • Description updated (diff)

#6 Updated by tinita 3 months ago

  • Status changed from Workable to In Progress
  • Assignee set to tinita

#7 Updated by openqa_review 3 months ago

  • Due date set to 2021-11-19

Setting due date based on mean cycle time of SUSE QE Tools

#8 Updated by tinita 3 months ago

I adjusted the code to retrieve comments from redmine tickets, but I have more issues to solve:

  • black reports that the Issue.__init__ method is now too complex
  • there is a partially covered line resulting in <100% coverage
  • It's not clear how to get a HTML coverage report that tells me what exactly is not covered
  • Would be nice if the CI created a HTML coverage report

#9 Updated by tinita 2 months ago

  • Status changed from In Progress to Feedback

PR https://github.com/os-autoinst/openqa_review/pull/190 "Retrieve comments from redmine tickets" was merged.

PR https://github.com/os-autoinst/openqa_review/pull/191 "Document how to locally test" was merged.

#10 Updated by okurz 2 months ago

  • Related to action #102200: openqa-review pipeline failed: 'NoneType' object is not subscriptable, or failed with `assert self.issue_type == "bugzilla"` size:M added

#11 Updated by tinita 2 months ago

PR 190 created a regression, see also #102200

PR to fix: https://github.com/os-autoinst/openqa_review/pull/192 Ensure that last_comment_text is not None

#12 Updated by tinita 2 months ago

  • Status changed from Feedback to Resolved

Regression fixed

#13 Updated by okurz about 1 month ago

  • Due date deleted (2021-11-19)

Also available in: Atom PDF