Project

General

Profile

coordination #98457

Updated by okurz over 2 years ago

## Motivation 
 openqa-review puts reminder comments jobs even they are multiple months old. This can be confusing to some users and the existing options in https://github.com/os-autoinst/openqa_review/blob/master/openqa_review/openqa_review.py#L196 might not be good enough for some users. 
 Also see https://suse.slack.com/archives/C02CANHLANP/p1631255003169600 

 ## Ideas 

 * Don't comment if the content of the comment would be the same with same job. 
 * Suggestion by foursixnine: Don't comment at all on a job result that is multiple months old. okurz sees a problem with that approach because if these results are still the "most recent" ones then users might be able to follow why such jobs would not be referenced in reminder comments. 
 * *DONE* Maybe just extend the reminder comment with the option to specify a label instead of a bugref, e.g. `label:wontfix:bsc1234` -> https://github.com/os-autoinst/openqa_review/pull/177 
 * Additional suggestions by mdoucha: Don't remind on soft-fails: "Most soft-fails in kernel groups are WONTFIX issues and stuff that isn't important enough to fix immediately. We know about it, we'll fix what needs to be fixed eventually, we don't need a reminder". This seems to be a squad specific workflow which is not generally true. So here I would stick with the current behaviour.

Back