action #106368
closedcoordination #91646: [saga][epic] SUSE Maintenance QA workflows with fully automated testing, approval and release
coordination #98457: [epic] Handle openqa-review reminder comments on very old jobs better
openqa-review: Configurable no-reminder message pattern size:M
0%
Description
Motivation¶
See #104577
Have a configurable blocklist message or pattern and when encountered no reminders are sent. For that configuration option we should provide a sane default, e.g. as regex "(WONTFIX|NO_REMINDER)".
Acceptance criteria¶
- AC1: No reminder comment is sent on bugzilla or progress.opensuse.org from openqa-review if the text from
record_soft_failureincludes NO_REMINDER - AC2: For openqa.suse.de and openqa.opensuse.org in particular same as AC1 but for the word "WONTFIX"
Suggestions¶
- Find examples of openQA jobs that use a custom string to the os-autoinst testapi function
record_soft_failure, e.g. https://openqa.suse.de/tests/7817940#step/cfs_bandwidth01/15 - Look up where this text is parsed in https://github.com/os-autoinst/openqa_review/blob/master/openqa_review/openqa_review.py then skip reminder comments when there is special text in there, e.g. in https://github.com/os-autoinst/openqa_review/blob/master/openqa_review/openqa_review.py#L1534 skip if the text is "NO_REMINDER" by default, but configurable
- For AC2 consider putting the configuration for WONTFIX in https://gitlab.suse.de/openqa/openqa-review/-/blob/master/review-jobs.yml#L1
Updated by livdywan about 2 years ago
- Subject changed from openqa-review: Configurable no-reminder message pattern to openqa-review: Configurable no-reminder message pattern size:M
- Description updated (diff)
- Status changed from New to Workable
Updated by jbaier_cz about 2 years ago
- Status changed from Workable to In Progress
- Assignee set to jbaier_cz
It seems pretty straight-forward and it is a good opportunity to see more into openqa-review, so I will take it and try.
Updated by openqa_review about 2 years ago
- Due date set to 2022-02-25
Setting due date based on mean cycle time of SUSE QE Tools
Updated by jbaier_cz about 2 years ago
- Status changed from In Progress to Feedback
I created https://github.com/os-autoinst/openqa_review/pull/208 to target this issue.
Updated by okurz about 2 years ago
PR merged. Please on the next calls of pipelines in gitlab.nue.suse.com/openqa/openqa_review monitor according reminder comments to check that at best (a) they still work in general, (b) no further reminder comments for NO_REMINDER|WONTFIX issues. I am thinking, where else should we provide a documentation for this feature?
Updated by jbaier_cz about 2 years ago
okurz wrote:
(a) they still work in general
They still work, see https://progress.opensuse.org/issues/57464
(b) no further reminder comments for NO_REMINDER|WONTFIX issues
If I am not mistaken, https://bugzilla.suse.com/show_bug.cgi?id=1191232 would be commented on Monday
Updated by jbaier_cz about 2 years ago
- Due date deleted (
2022-02-25) - Status changed from Feedback to Resolved
The openQA test is still failing and yet, there is no new message about it in bsc#1191232.