Project

General

Profile

Actions
Copy link

action #100982

closed

coordination #91646: [saga][epic] SUSE Maintenance QA workflows with fully automated testing, approval and release

coordination #98457: [epic] Handle openqa-review reminder comments on very old jobs better

openqa-review: Do not post reminder comment if comment would be exactly the same as the last size:M

Added by okurz about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
jbaier_cz
Target version:
openQA Project - Ready
Start date:
2021-10-14
Due date:
% Done:

0%

Estimated time:

Description

Motivation

openqa-review puts reminder comments jobs even they are multiple months old. This can be confusing to some users and the existing options in https://github.com/os-autoinst/openqa_review/blob/master/openqa_review/openqa_review.py#L196 might not be good enough for some users.
Also see https://suse.slack.com/archives/C02CANHLANP/p1631255003169600

Acceptance criteria

  • AC1: No comment is posted if the content of the comment would be the same with same job

Suggestions

  • Look into openqa-review where we post reminder comments, read the last comment, if it's just the very same text that we would write, don't write it, just log_debug or something

Related issues 1 (0 open — 1 closed)

Copied to QA - action #101722: openqa-review: Do not post reminder comment in progress.opensuse.org if comment would be exactly the same as the last size:MResolvedtinita2021-10-14

Actions
Actions
Copy link
 #1

Updated by mkittler about 3 years ago

  • Tracker changed from coordination to action
  • Subject changed from openqa-review: Only post reminder comment if comment would be exactly the same as the last to openqa-review: Do not post reminder comment if comment would be exactly the same as the last size:M
  • Status changed from New to Workable
Actions
Copy link
 #2

Updated by jbaier_cz about 3 years ago

  • Assignee set to jbaier_cz
Actions
Copy link
 #3

Updated by jbaier_cz about 3 years ago

  • Status changed from Workable to In Progress
Actions
Copy link
 #4

Updated by openqa_review about 3 years ago

  • Due date set to 2021-11-02

Setting due date based on mean cycle time of SUSE QE Tools

Actions
Copy link
 #5

Updated by jbaier_cz about 3 years ago

Drafted a PR, I am not satisfied with the tests. Although I based it on test_reminder_comments_on_referenced_bugs_are_posted, that test in fact does not check if those comments were really posted, so I have currently no way to see, if my code posted one comment less. Need to find a way to count the posts, probably.

Actions
Copy link
 #6

Updated by jbaier_cz about 3 years ago

  • Status changed from In Progress to Feedback

Added some tests, so now the calls are actually counted and asserted. Waiting for merge.

Actions
Copy link
 #7

Updated by jbaier_cz about 3 years ago

  • Status changed from Feedback to Resolved
Actions
Copy link
 #8

Updated by jbaier_cz about 3 years ago

  • Copied to action #101722: openqa-review: Do not post reminder comment in progress.opensuse.org if comment would be exactly the same as the last size:M added
Actions
Copy link
 #9

Updated by okurz about 3 years ago

  • Due date deleted (2021-11-02)
Actions
Copy link

Also available in: Atom PDF