QA (public) » openQA Project (public)

Some suggestions how the display could be improved:

• If the test (soft)failed, collapse green test modules (except for a linked #anchor), those aren't the main point of interest anyway
• Treat successive terminal output/input more like an actual terminal and use an inline line break instead of separate boxes
• If the output matched, only show the output (with leading and trailing newlines removed) and not the "# wait_serial expected..." and "result:" lines
• If the space is too narrow for the "Report bug" buttons, hide them until the relevant step is clicked or hovered

PR (first step): https://github.com/os-autoinst/openQA/pull/3350

Treat successive terminal output/input more like an actual terminal and use an inline line break instead of separate boxes

That's a good idea. So the "wavpack" module in the screenshot of my initial change (https://github.com/os-autoinst/openQA/pull/3340) would have only one expandable box. I guess the individual serial outputs could be separated via horizontal lines.

If the output matched, only show the output (with leading and trailing newlines removed) and not the "# wait_serial expected..." and "result:" lines

But isn't the regex sometimes used to figure where the check comes from (test code) and what the purpose of the check was?

favogt wrote:

Some suggestions how the display could be improved:

Revealing each result by click is really annoying.

• if there is need of the reveal, do it for whole test.
• output should be more readable, if it's like side diff:

green for match

# wait_serial    | # Results:
> qr/1mAID-\d+-/ |  \textcolor{green}{> 1mAID-0-}

red for not match

# wait_serial    | # Results:
> qr/1mAID-\d+-/ |   \textcolor{red}{> 1mAID-1-}

favogt wrote:

• Treat successive terminal output/input more like an actual terminal and use an inline line break instead of separate boxes

I'd keep the boxes as quick links into the single long terminal view. When you click the box, it'll open the terminal view and jump to the location of the corresponding output.

mkittler wrote:

If the output matched, only show the output (with leading and trailing newlines removed) and not the "# wait_serial expected..." and "result:" lines

But isn't the regex sometimes used to figure where the check comes from (test code) and what the purpose of the check was?

I'd much prefer to get rid of the # wait_serial expected: blahblahblah as much as possible. The following output format would be much easier to work with. Bold lines represent extra info from OpenQA and would be highlighted with different colors:

boot_ltp.pm:67: script_run('ps axf');
PID TTY STAT TIME COMMAND
2 ? S 0:00 [kthreadd]
3 ? S 0:00 _ [kworker/0:0]
4 ? S< 0:00 _ [kworker/0:0H]
... (snip)
1407 ? Ss 0:00 /usr/sbin/cron -n
1413 ? Ss 0:00 /usr/lib/systemd/systemd --user
1414 ? S 0:00 _ (sd-pam)
Command exit code: 0

boot_ltp.pm:69: script_run('aa-enabled; aa-status');
If 'aa-enabled' is not a typo you can use command-not-found to lookup the package that contains it, like this:
cnf aa-enabled
apparmor module is loaded.
0 profiles are loaded.
0 profiles are in enforce mode.
0 profiles are in complain mode.
0 processes have profiles defined.
0 processes are in enforce mode.
0 processes are in complain mode.
0 processes are unconfined but have a profile defined.
Command exit code: 2

boot_ltp.pm:131: script_run('grep -e Huge -e PageTables /proc/meminfo');
Serial terminal error
wait_serial expected: "grep -e Huge -e PageTables /proc/meminfo; echo zlQih-\$?-"
Result: grep -e Huge -e PageTables /proc/meminfo; eccccccc

@mkittler the new new design seems to be ok for most. Could you please add the still open points as ideas to #65271 and close this ticket then?