action #57143
closed[YAML] Editor does not check if same combination of test suite/arch/flavor/version already used in different job group
0%
Description
In legacy Job Group Editor you were not able to add a second combination of the same test suite + arch + flavor + version. It was also not possible if the job group was different. In this case you've got an SQL error (see the related ticket).
In the YAML Job Group editor you can have the same 'test suite + arch + flavor + version' combination twice in different job groups. E.g. on OSD we currently have:
defaults:
x86_64:
machine: 64bit
priority: 50
products:
sle-15-SP2-Installer-DVD-x86_64:
distri: sle
flavor: Installer-DVD
version: 15-SP2
scenarios:
x86_64:
sle-15-SP2-Installer-DVD-x86_64:
- wicked_basic_sut
- wicked_advanced_ref
- wicked_advanced_sut
- wicked_startandstop_sut
- wicked_startandstop_ref
- wicked_basic_ref
and
defaults:
aarch64:
machine: aarch64
priority: 50
x86_64:
machine: 64bit
priority: 50
products:
sle-15-SP2-Installer-DVD-aarch64: &products
distri: sle
flavor: Installer-DVD
version: 15-SP2
sle-15-SP2-Installer-DVD-x86_64:
*products
scenarios:
aarch64:
sle-15-SP2-Installer-DVD-aarch64: &tests
- wicked_basic_sut: &general_settings
settings:
DESKTOP: textmode
EXTRATEST: wicked
KEEP_GRUB_TIMEOUT: '1'
VIDEOMODE: text
WICKED_TCPDUMP: '1'
VIRTIO_CONSOLE_NUM: '2'
- wicked_advanced_ref:
*general_settings
- wicked_advanced_sut:
*general_settings
- wicked_startandstop_sut:
*general_settings
- wicked_startandstop_ref:
*general_settings
- wicked_basic_ref:
*general_settings
- wicked_aggregate_sut:
*general_settings
- wicked_aggregate_ref:
*general_settings
- create_hdd_autoyast_wicked:
settings:
AUTOYAST: autoyast_sle15/autoyast_wicked_%ARCH%.xml
priority: 45
x86_64:
sle-15-SP2-Installer-DVD-x86_64:
*tests
in the job groups 117 (SLE 15 Development -> Network) and 262 (SLE 15 -> Network).
This leads to the job being scheduled twice when posting a new ISO. Considering that the job templates actually exist twice this is expected behavior. The question is whether we want to allow the same 'test suite + arch + flavor + version' combination in different job groups.
(Note that the ticket from @asmorodskyi implies that the new editor should check this as the old editor did. I personally would leave this open for discussion.)