Actions
action #39869
closed[sle][functional][u] do not use version in repo variable names (was: test fails in kdump_and_crash - missing SP1 repo variable in get_repo_url_for_kdump_sle subroutine)
Status:
Resolved
Priority:
Normal
Assignee:
Category:
Bugs in existing tests
Target version:
SUSE QA - Milestone 19
Start date:
2018-08-16
Due date:
2018-10-09
% Done:
0%
Estimated time:
Difficulty:
easy
Description
Observation¶
openQA test in scenario sle-15-SP1-Installer-DVD-ppc64le-toolchain_zypper@ppc64le fails in
kdump_and_crash
We are missing sles-server debug repo because of incorrect openQA variable (should be REPO_SLE15_SP1_MODULE_BASESYSTEM_DEBUG).
sub get_repo_url_for_kdump_sle {
return join('/', $utils::OPENQA_FTP_URL, get_var('REPO_SLE15_MODULE_BASESYSTEM_DEBUG'))
if get_var('REPO_SLE15_MODULE_BASESYSTEM_DEBUG')
and is_sle('15+');
return join('/', $utils::OPENQA_FTP_URL, get_var('REPO_SLES_DEBUG')) if get_var('REPO_SLES_DEBUG');
}
In the main.pm we have code to inject version
my $repo_variable_name
= is_module($short_name) ?
"REPO_SLE${version}_MODULE_${repo_name}"
: "REPO_SLE${version}_PRODUCT_${repo_name}";
In general it doesn't make sense to have version in the variable names. For that we should introduce changes to rsync.pl and then adjust tests code all usages of REPO_SLE_xxx
This will simplify test code and will work in future, as we already had to introduce fix for SP1 in main.pm to replace - with _
Acceptance criteria¶
- REPO_ variables do not include version in the name ## Reproducible
Fails since (at least) Build 19.7
Expected result¶
Last good: SLE15GM
Further details¶
Always latest result in this scenario: latest
Actions