QA (public) » openQA Project (public) » openQA Tests (public)

An alternative solution, instead of adjusting the openQA test code, would be for the -testsuite package to require systemd-container; this might be even cleaner (but since nothing of that is in the product, I can't call this a product bug, thus stays here).

Please coordinate with Thomas Blume about the solution, and about the project on OBS where those test suites shall live. Currently they are in a home: space

Sergio,

We now have a project called devel:openSUSE:QA - where we can collect such things together. I can assign you maintainer rights on this prj if you want (imho, this should be owned by QA)

tblume fixes the systemd-testsuite to install the systemd-container package: https://build.opensuse.org/package/rdiff/home:tsaupe:testsuites/systemd-v234-testsuite?linkrev=base&rev=11

PR with workaround: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4591

Test suite for v234 on openSUSE Leap 15 ready in https://build.opensuse.org/package/show/devel:openSUSE:QA/systemd-v234-testsuite

Test suite for v228 on openSUSE Leap 42.3 ready in: https://build.opensuse.org/package/show/devel:openSUSE:QA/systemd-v228-testsuite

This is an autogenerated message for openQA integration by the openqa_review script:

This bug is still referenced in a failing openQA test: suse_patches-systemd_testsuite
https://openqa.opensuse.org/tests/644096

PR to improve test results: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4795

Pending tasks:

• Fix broken test suite package for Tumbleweed:
  • Last code: https://build.opensuse.org/package/show/home:tsaupe:testsuites/systemd-v237-testsuite
  • Target OBS project: https://build.opensuse.org/package/show/devel:openSUSE:QA:Tumbleweed/systemd-v237-testsuite
• Fix missing dependency systemd-container
  • For some reason the dependency is ignored, causing the test to fail trying to execute nspawn.

SR: https://build.opensuse.org/request/show/595166

Settings for test suite suse_patches-systemd_testsuite on https://openqa.opensuse.org changed to QA_HEAD_REPO=https://download.opensuse.org/repositories/devel:/openSUSE:/QA:/%VERSION%/openSUSE_%VERSION%

SLindoMansilla wrote:

• Fix missing dependency systemd-container
  • For some reason the dependency is ignored, causing the test to fail trying to execute nspawn.

Found your flaw. You added the "Require" to the base package, that is systemd itself. systemd-v234-testsuite is a subpackage so you have to put the Require there. Patch:

$ osc diff
Index: systemd-v234-testsuite.spec
===================================================================
--- systemd-v234-testsuite.spec (revision 45efb95fc34b593ec7ed380437a085bd)
+++ systemd-v234-testsuite.spec (working copy)
@@ -120,7 +120,6 @@
 Requires:       udev = %{version}-%{release}
 Requires:       util-linux >= 2.27.1
 Requires:       group(lock)
-Requires:       systemd-container
 Recommends:     %{name}-bash-completion
 Requires(post): coreutils
 Requires(post): findutils
@@ -419,6 +418,7 @@
 Summary:        Test suite for QA
 License:        LGPL-2.1+
 Group:          System/Benchmark
+Requires:       systemd-container

 %description v%{version}-testsuite
 This provides the system testsuite scripts and binaries for QA

-> https://build.suse.de/request/show/161525

I will leave the synchronisation with openSUSE to you but I strongly suggest to come up with an automatic approach. Also I think it's a good idea to disable the build on all unsupported repositories.

I applied your patch. Now I have a versioning problem due to the _service file. Fixing it.

what is a "versioning problem"?

The hash of the build was included in the namespace of the package, so instead of systemd-v238-testsuite, it was systemd-v238.suse.20180328.g14b3e00c3-3.1.x86_64.rpm.

I had problems trying to remove the hash, set on _service, so I decided to make the package name version independent: https://build.opensuse.org/request/show/595918

PR to adapt the test: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4839

Merged. Verified on O3: https://openqa.opensuse.org/tests/655873

Building before SR: https://build.opensuse.org/package/live_build_log/home:SLindoMansilla:branches:devel:openSUSE:QA:Leap:15/systemd-v234-testsuite/openSUSE_Leap_15.0/x86_64

SR: https://build.opensuse.org/request/show/596839

Accepted.

PR for systemd: https://github.com/openSUSE/systemd/pull/12

The fix was there but not merged for SLE15: https://github.com/openSUSE/systemd/commit/04ef8e53582b7dc29fb1c6981a0243ec32b17c9e

Fix for systemd-container on Leap15 verified on O3: https://openqa.opensuse.org/tests/657011#step/systemd_testsuite/20

PR for Leap15: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4866

Merged.

Verified:

• O3, Leap15: https://openqa.opensuse.org/tests/658284
• OSD, SLE15:
  • aarch64: https://openqa.suse.de/tests/1627349 (fail bacause of https://progress.opensuse.org/issues/35143)
  • ppc64le: https://openqa.suse.de/tests/1627350 (fail bacause of https://progress.opensuse.org/issues/35143)
  • s390x: https://openqa.suse.de/tests/1627343 (fail because of https://progress.opensuse.org/issues/35143)
  • x86_64: https://openqa.suse.de/tests/1627342

any update in this? it keeps failing in leap 15

Yes, this problem is solved. Now, it was failing because a bug on the syntax rule checker.
I have tried to updated the package on OBS, but it fails building, I am working to fix it on: https://progress.opensuse.org/issues/35035#note-7