action #174235
closedcoordination #127031: [saga][epic] openQA for SUSE customers
coordination #130414: [epic] Improved code coverage in os-autoinst
Cover code of os-autoinst path script/os-autoinst-openvswitch fully (statement coverage) size:S
Added by okurz 5 months ago. Updated 2 months ago.
Description
Acceptance criteria¶
- AC1: the path script/os-autoinst-openvswitch is listed in codecov.yml under "fully_covered"
Suggestions¶
- Take a look into https://app.codecov.io/gh/os-autoinst/os-autoinst/blob/master/script%2Fos-autoinst-openvswitch about what is missing
- Add unit test statement coverage for that to bump the target
Updated by okurz 5 months ago
- Copied from action #174232: Cover code of os-autoinst path script/dewebsockify fully (statement coverage) size:S added
Updated by okurz 5 months ago
- Copied to action #174238: Cover code of os-autoinst path script/vnctest fully (statement coverage) size:S added
Updated by gpuliti 4 months ago ยท Edited
I started the work extracting the subroutine of the scripts into a module inside OpenQA dir following what have been done for #174232. After discussing it with in slack with oliver I've switch to another method of covering scripts and following what's have been done with #174238.
I'm now encounter this error t/41-openswitch.t .. org.freedesktop.DBus.Error.AccessDenied: Request to own name refused by policy I think something needs to be run first before executing the tests.
Updated by gpuliti 4 months ago
Opened a not ready draft pull request: https://github.com/os-autoinst/os-autoinst/pull/2642
Updated by gpuliti 3 months ago
- Assignee deleted (
gpuliti)
The first approach I had was to extract from the script subroutines and create a new module as utility of openQA (like #174232), but after conversations with the team we decide that it's more reliable to follow what have been done in #174238 and make the original script importable.
I've done some changes here https://github.com/os-autoinst/os-autoinst/pull/2642 but it is really WIP.
I'm removing me from the assignee due to vacation period.
Updated by openqa_review 3 months ago
- Due date set to 2025-03-14
Setting due date based on mean cycle time of SUSE QE Tools
Updated by gpuliti 3 months ago
Open a new pr: https://github.com/os-autoinst/os-autoinst/pull/2673
mainly thing on how to mock and test, also extract the package into a new module.
Updated by gpuliti 3 months ago
- Copied to action #178204: Reduce test start time on openqa.suse.de size:S added
Updated by gpuliti 3 months ago
- Copied to deleted (action #178204: Reduce test start time on openqa.suse.de size:S)
Updated by gpuliti 3 months ago
based on https://app.codecov.io/gh/os-autoinst/os-autoinst/pull/2673/indirect-changes ~17% has been covered, but I think there are some problems with line 239 because the script stops during the call of $bus->export_service("org.opensuse.os_autoinst.switch") maybe I need to mock it
Updated by okurz 2 months ago
- Copied to action #178963: Regression in script/os-autoinst-openvswitch auto_review:"Too few arguments for subroutine 'OVS::_set_ip'":retry added