action #162035
opencoordination #58184: [saga][epic][use case] full version control awareness within openQA
coordination #88561: [epic] Extend needle version control handling
Support development of "Use needles from correct ref of NEEDLES_DIR" https://github.com/os-autoinst/openQA/pull/5175 size:M
Description
Motivation¶
It can be confusing to not see candidate needles on the web UI that were not available at the time the test was being executed.
Acceptance criteria¶
- AC1: The candidates view on the test details pages shows candidate needles of the version that was used when the test was executed.
- AC2: Temporary needles are cleaned up (instantly or on a schedule)
- AC3: The needle editor still shows the last candidates. One might optionally show there the candidates at the time the test ran as well.
Suggestions¶
- Read exactly what the PR "Use needles from correct ref of NEEDLES_DIR" is about
- Checkout #154783-10 and further comments for what's missing
- Review the code and make suggestions or add changes yourself to get it merged
- Make sure test coverage is appropriate (PR does not look like it atm.)
- If any work becomes too much work then split out into separate explicit tickets and provide explicit feedback to the PR author about what is expected from them and what can be expected from us
- Saying no to a feature is always an option too
- Consider a NEEDLES_DIR being a different repo/remote entirely (e.g. a pull request) (although this is not strictly required it would be good to ensure we could also support it)
- Read #56789 again
Updated by okurz 5 months ago
- Subject changed from Support development of https://github.com/os-autoinst/openQA/pull/5175 to Support development of "Use needles from correct ref of NEEDLES_DIR" https://github.com/os-autoinst/openQA/pull/5175 size:M
- Description updated (diff)
- Status changed from New to Workable
Updated by openqa_review 3 months ago
- Due date set to 2024-09-03
Setting due date based on mean cycle time of SUSE QE Tools
Updated by tinita 3 months ago
- Status changed from In Progress to Feedback
I tried out the pull request locally and added some notes: https://github.com/os-autoinst/openQA/pull/5175
Still need to understand all of it...
Updated by livdywan 3 months ago
- Related to action #56789: New needles from git repository not working with openqa-clone-custom-git-refspec added
Updated by tinita 3 months ago
- Related to action #157159: Show version of candidate needles the test ran on in the "diff view" on the test details page added
Updated by livdywan about 2 months ago
Waiting for a response for now
No response so far. Might just need to wait for Scott to make time for it.
Asked once more.
Updated by livdywan about 2 months ago
- Status changed from Blocked to Workable
Scott confirmed the AC's we came up with but seems to have no time to work on this for now. The PR has some conflicts. Maybe this can be considered unblocked.
Updated by ybonatakis about 1 month ago
Let's wait for Liv to return from vacation next week!?!
Updated by openqa_review 28 days ago
- Due date set to 2024-11-05
Setting due date based on mean cycle time of SUSE QE Tools
Updated by livdywan 27 days ago
Discussed in the unblock
- https://github.com/os-autoinst/openQA/pull/5175 rebased
- I dropped the use of File::Touch which we don't depend on (I was confused by the CI results but the fix was straightforward)
- Looking into coverage gaps which are now also visible on the PR
- Most importantly the candidates view
- Needle editing looks to be using the new code, too, but is not required
- Check how to reproduce the new feature manually e.g. using NEEDLES_DIR/other test vars (same in unit tests)