Project

General

Profile

Actions

action #164883

closed

coordination #58184: [saga][epic][use case] full version control awareness within openQA

coordination #152847: [epic] version control awareness within openQA for test distributions

Use same minion guard for save_needle, delete_needles and git_clone size:S

Added by tinita 5 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Feature requests
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Motivation

See #162125

All minion jobs that update git repositories should use the same minion guard to avoid conflicts

Currently we have these:

https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Task/Git/Clone.pm#L33

my $guard = $app->minion->guard("git_clone_${path}_task", 2 * ONE_HOUR);

https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Task/Needle/Save.pm#L58

unless my $guard = $app->minion->guard('limit_needle_task', 7200);

https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Task/Needle/Delete.pm#L20

unless my $guard = $app->minion->guard('limit_needle_task', 7200);

Suggestion: Use git_update_${path}_task for all three.

Acceptance Criteria

  • AC1: Git minion operations can't interfere with each other

Suggestions

  • In the needle tasks, figure out the path of the git operation first and use it for the guard
  • Wait for #164886

Related issues 2 (0 open2 closed)

Related to openQA Project (public) - action #164898: Replace fetchneedles with a minion job for the regular update of git repos size:MResolvedtinita

Actions
Copied from openQA Project (public) - action #162125: [timeboxed:10h][spike] Let openQA keep test distribution checkouts up to date without needing fetchneedles size:SResolvedtinita2024-06-12

Actions
Actions

Also available in: Atom PDF