Project

General

Profile

action #164883

Updated by tinita 5 months ago

## Motivation 

 See #162125  

 All minion jobs that update git repositories should use the same minin guard to avoid conflicts 

 Currently we have these: 

 https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Task/Git/Clone.pm#L33 
 ``` 
 my $guard = $app->minion->guard("git_clone_${path}_task", 2 * ONE_HOUR); 
 ``` 
 https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Task/Needle/Save.pm#L58 
 ``` 
 unless my $guard = $app->minion->guard('limit_needle_task', 7200); 
 ``` 
 https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Task/Needle/Delete.pm#L20 
 ``` 
 unless my $guard = $app->minion->guard('limit_needle_task', 7200); 
 ``` 

 Suggestion: Use `git_update_${path}_task` for all three. 


 ## Acceptance Criteria 

 * **AC1:** Git minion operations can't interfere with each other 


 ## Suggestions 
 * In the needle tasks, figure out the path of the git operation first and use it for the guard

Back