QA » openQA Project

https://github.com/os-autoinst/openQA/pull/5854 Extend test coverage of OpenQA::Git

https://github.com/os-autoinst/openQA/pull/5863 Refactor PR turning generic functions of OpenQA::Task::Git:Clone into methods of OpenQA::Git including other minor refactors for the module.

https://github.com/os-autoinst/openQA/pull/5863 merged.

We see a failure now:
https://openqa.opensuse.org/tests/4422586#step/test_running/8
https://openqa.opensuse.org/tests/4422583/logfile?filename=test_running-openqa_services.log.txt

Aug 22 06:05:13 susetest openqa-gru[65311]: [info] Running cmd: env GIT_SSH_COMMAND=ssh -oBatchMode=yes git -C /var/lib/openqa/share/tests/example ls-remote --symref https://github.com/os-autoinst/os-autoinst-distri-example.git HEAD
Aug 22 06:05:14 susetest openqa-gru[65311]: [warn] fatal: cannot change to '/var/lib/openqa/share/tests/example': No such file or directory
Aug 22 06:05:14 susetest openqa-gru[65311]: [error] cmd returned 32768

Revert https://github.com/os-autoinst/openQA/pull/5880 was already merged.

I think there are two things that can be improved:

• The -C /dir is harmful if we call the ls-remote before the intial clone, so I guess we do need an option to leave out the -C for some commands
• The ls-remote is called before the initial clone. But if we don't have the existing clone, we just need to do a clone and never need the ls-remote, and we don't even need the following fetch if we just did a clone, so the code can also be improved in that regard.

I prepared a PR which improves the order of the git commands and also gets rid of some calls this way: https://github.com/os-autoinst/openQA/pull/5884

The original problem should not appear anymore with your refactoring branch, but still it might make sense to only add -C ... when needed. Not sure yet how that could look like.

https://github.com/os-autoinst/openQA/pull/5884 merged.
I hope it's not too annoying to rebase your refactoring on top of it @robert.richardson

https://github.com/os-autoinst/openQA/pull/5900 Refactor git functionality into OpenQA::Git (merged)