Project

General

Profile

Actions
Copy link

action #164883

open

coordination #58184: [saga][epic][use case] full version control awareness within openQA

coordination #152847: [epic] version control awareness within openQA for test distributions

Use same minion guard for save_needle, delete_needles and git_clone size:S

Added by tinita 14 days ago. Updated about 4 hours ago.

Status:
In Progress
Priority:
Normal
Assignee:
tinita
Category:
Feature requests
Target version:
Ready
Start date:
Due date:
2024-08-29 (Due in 13 days)
% Done:

0%

Estimated time:

Description

Motivation

See #162125

All minion jobs that update git repositories should use the same minion guard to avoid conflicts

Currently we have these:

https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Task/Git/Clone.pm#L33

my $guard = $app->minion->guard("git_clone_${path}_task", 2 * ONE_HOUR);

https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Task/Needle/Save.pm#L58

unless my $guard = $app->minion->guard('limit_needle_task', 7200);

https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Task/Needle/Delete.pm#L20

unless my $guard = $app->minion->guard('limit_needle_task', 7200);

Suggestion: Use git_update_${path}_task for all three.

Acceptance Criteria

  • AC1: Git minion operations can't interfere with each other

Suggestions

  • In the needle tasks, figure out the path of the git operation first and use it for the guard
  • Wait for #164886

Related issues 2 (1 open — 1 closed)

Related to openQA Project - action #164898: Replace fetchneedles with a minion jobBlockedtinita

Actions
Copied from openQA Project - action #162125: [timeboxed:10h][spike] Let openQA keep test distribution checkouts up to date without needing fetchneedles size:SResolvedtinita2024-06-122024-08-13

Actions
Actions
Copy link
 #1

Updated by tinita 14 days ago

  • Copied from action #162125: [timeboxed:10h][spike] Let openQA keep test distribution checkouts up to date without needing fetchneedles size:S added
Actions
Copy link
 #2

Updated by tinita 14 days ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by jbaier_cz 14 days ago

  • Subject changed from Use same minion gard for save_needle, delete_needles and git_clone to Use same minion guard for save_needle, delete_needles and git_clone
Actions
Copy link
 #4

Updated by jbaier_cz 14 days ago

  • Target version set to Ready
Actions
Copy link
 #5

Updated by tinita 14 days ago

  • Related to action #164898: Replace fetchneedles with a minion job added
Actions
Copy link
 #6

Updated by tinita 11 days ago

  • Description updated (diff)
Actions
Copy link
 #7

Updated by livdywan 8 days ago

  • Subject changed from Use same minion guard for save_needle, delete_needles and git_clone to Use same minion guard for save_needle, delete_needles and git_clone size:S
  • Description updated (diff)
  • Status changed from New to Workable
Actions
Copy link
 #8

Updated by tinita 3 days ago

  • Assignee set to tinita
Actions
Copy link
 #9

Updated by tinita 2 days ago

  • Status changed from Workable to In Progress

So delete_needles seems to be only about database, while save_needle is about the database plus git, and git_clone is about git.
It seems to be possible to have more than one guard for a job, so I would just add the limit_needle guard to the git_clone job.

Actions
Copy link
 #10

Updated by tinita 2 days ago ยท Edited

Related: https://github.com/os-autoinst/openQA/pull/5857 t: Avoid tampering with git checkout (merged)

Actions
Copy link
 #11

Updated by openqa_review 1 day ago

  • Due date set to 2024-08-29

Setting due date based on mean cycle time of SUSE QE Tools

Actions
Copy link
 #12

Updated by tinita about 4 hours ago

https://github.com/os-autoinst/openQA/pull/5862 Prevent git_clone to interfere with needle tasks

Actions
Copy link

Also available in: Atom PDF