action #130420
closedcoordination #127031: [saga][epic] openQA for SUSE customers
coordination #130414: [epic] Improved code coverage in os-autoinst
Improved code coverage in os-autoinst - testapi size:S
Description
Motivation¶
To be able to safely improve and extend os-autoinst, we need to have reliable and stable unit tests with even better code coverage, at least 100% statement coverage. Continue with the path "testapi.pm"
Acceptance criteria¶
- AC1: codecov.yml ensures that we have 100.00% statement coverage (with explicit Devel::Cover exceptions allowed) for the path "testapi.pm"
Suggestions¶
- Identify areas showing less than 100.00% on https://app.codecov.io/gh/os-autoinst/os-autoinst/blob/master/testapi.pm and
- Remove dead code
- As desired collect coverage locally as documented in the README, e.g.
make coverage - Consider just looking at the web interface to verify current coverage (no need to reproduce reports locally)
- Add according test coverage
- Add explicit exception statements on unreachable code
- Add testapi.pm to codecov.yml "fully_covered" until the complete project reaches 100%
Out of scope¶
- Tests related to openQA or database-related
Updated by okurz over 1 year ago
- Copied from action #130417: Improved code coverage in os-autoinst - consoles/amtSol or remove along with the deprecated backend size:S added
Updated by okurz over 1 year ago
- Copied to action #130423: Improved code coverage in os-autoinst - all the rest added
Updated by okurz 4 months ago
- Copied to action #165396: Improved code coverage in openQA for unit tests in t/ size:S added
Updated by dheidler about 2 months ago
- Status changed from In Progress to Workable
- Assignee deleted (
dheidler)
I got the coverage up from 86% to 95% but now the only the nasty bits are left.
See https://app.codecov.io/gh/os-autoinst/os-autoinst/blob/asdil12%2Fos-autoinst%3Atestapi-coverage/testapi.pm
Mostly _handle_found_needle and some lines of _check_backend_response as well as assert_screen_change.
I'm not really making progress there so I'm leaving this ticket for someone else to continue working on.
Updated by mkittler about 2 months ago
- Status changed from Workable to In Progress
- Assignee set to mkittler
Updated by mkittler about 2 months ago
Updated by mkittler about 2 months ago
- Status changed from In Progress to Feedback
PR covering the last so far uncovered lines: https://github.com/os-autoinst/os-autoinst/pull/2559
Updated by mkittler about 2 months ago
- Status changed from Feedback to Resolved
The PR has been merged.