Project

General

Profile

Actions
Copy link

action #130417

closed

coordination #127031: [saga][epic] openQA for SUSE customers

coordination #130414: [epic] Improved code coverage in os-autoinst

Improved code coverage in os-autoinst - consoles/amtSol or remove along with the deprecated backend size:S

Added by okurz over 1 year ago. Updated 26 days ago.

Status:
Resolved
Priority:
Low
Assignee:
ybonatakis
Category:
Feature requests
Target version:
Ready
Start date:
2023-06-06
Due date:
% Done:

0%

Estimated time:

Description

Motivation

To be able to safely improve and extend os-autoinst, we need to have reliable and stable unit tests with even better code coverage, at least 100% statement coverage. Continue with the directory "consoles/"

Acceptance criteria

  • AC1: codecov.yml ensures that we have at least 100% statement coverage (with explicit Devel::Cover exceptions allowed) for the file "consoles/amtSol" (if it still exists)

Suggestions

  • First consider if we can obsolete and delete the backend amt and according console (compare to previous obsoletions)
  • Identify areas showing less than 100.00% on https://app.codecov.io/gh/os-autoinst/os-autoinst/blob/master/consoles%2FamtSol.pm
    • Remove dead code
    • Add according test coverage
    • Add explicit exception statements on unreachable code
  • Add consoles/ to codecov.yml "fully_covered" until the complete project reaches 100%

Related issues 3 (1 open — 2 closed)

Related to openQA Project (public) - action #170476: Cover code of os-autoinst path backend/ fully (statement coverage) (again)Resolvedjbaier_cz2024-11-28

Actions
Copied to openQA Project (public) - action #130420: Improved code coverage in os-autoinst - testapi size:SResolvedmkittler2023-06-06

Actions
Copied to openQA Project (public) - action #168364: Improved code coverage in os-autoinst - consoles/s3270 size:MWorkable2023-06-06

Actions
Actions
Copy link
 #1

Updated by okurz over 1 year ago

  • Copied to action #130420: Improved code coverage in os-autoinst - testapi size:S added
Actions
Copy link
 #2

Updated by okurz 2 months ago

  • Target version changed from future to Ready
Actions
Copy link
 #3

Updated by okurz 2 months ago

  • Subject changed from Improved code coverage in os-autoinst - consoles to Improved code coverage in os-autoinst - consoles/amtSol or remove along with the deprecated backend size:S
  • Description updated (diff)
  • Status changed from New to Workable
Actions
Copy link
 #4

Updated by okurz 2 months ago

  • Copied to action #168364: Improved code coverage in os-autoinst - consoles/s3270 size:M added
Actions
Copy link
 #5

Updated by ybonatakis about 1 month ago

  • Status changed from Workable to In Progress
  • Assignee set to ybonatakis
Actions
Copy link
 #7

Updated by livdywan about 1 month ago

  • Status changed from In Progress to Feedback

Perhaps it should be in feedback if you're mainly waiting on input from others for now?

Actions
Copy link
 #8

Updated by okurz about 1 month ago

  • Due date set to 2024-11-25
  • Status changed from Feedback to In Progress
Actions
Copy link
 #9

Updated by ybonatakis about 1 month ago

  • Status changed from In Progress to Feedback

https://github.com/os-autoinst/os-autoinst/pull/2568#issuecomment-2468883009

amtSol seems that was deprecated 2 years ago. waiting for reply of how to continue

Actions
Copy link
 #10

Updated by livdywan 26 days ago

  • Due date changed from 2024-11-25 to 2024-11-29

ybonatakis wrote in #note-9:

https://github.com/os-autoinst/os-autoinst/pull/2568#issuecomment-2468883009

Let's aim to have it wrapped up this week. Last week was hackweek.

Actions
Copy link
 #11

Updated by ybonatakis 26 days ago

  • Status changed from Feedback to Resolved

merged

Actions
Copy link
 #12

Updated by okurz 26 days ago

  • Due date deleted (2024-11-29)
Actions
Copy link
 #13

Updated by okurz 24 days ago

  • Related to action #170476: Cover code of os-autoinst path backend/ fully (statement coverage) (again) added
Actions
Copy link

Also available in: Atom PDF