Project

General

Profile

Actions

action #10514

closed

[tools][sprint 201711.2] Prevent test module name clashes (problem on loading test module twice / multiple times / more than one)

Added by okurz over 8 years ago. Updated about 6 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Feature requests
Target version:
Start date:
2016-02-01
Due date:
% Done:

0%

Estimated time:

Description

user story

As a test organizer I want unique test module names to prevent ambiguity in references to tests

acceptance criteria

  • AC1: there is a check in "os-autoinst" for test module names
  • AC2: "make test" in os-autoinst-distri-opensuse fails with helpful error message when duplicate test module names are found

further notes

As coolo suggests in
https://github.com/os-autoinst/os-autoinst/pull/406/files#r51416668
"IMO loadtest should fail - right now it stores the tests in %tests by $fullname. I would make that fatal by $name"

Probably also needs rename of current tests in os-autoinst-distri-opensuse

In general we want a module to potentially appear multiple times within a testflow. openQA jobs can load test modules multiple times. However, when a job does this, the web UI does not show all the module executions. It only shows one execution for each module which is overwritten if the module is executed again., so for e.g. this test:

https://openqa.stg.fedoraproject.org/tests/72160

loads and runs _console_wait_login twice, as you can see from os-autoinst.log, but the web UI shows only one of the runs.

Although right now we have the same module name in different components we should try to avoid it as the URL does not differ, i.e. https://openqa.suse.de/tests/195580/modules/shutdown refers to "x11-shutdown" but the URL name is ambiguous.

An alternative solution to that problem might be to handle the same module being called multiple times and make it unique automatically, e.g. by adding a number when the module name is put into the webui display as well as the generated url to the module.


Related issues 3 (0 open3 closed)

Has duplicate openQA Project - action #17260: When a job loads module(s) more than once, the web UI only shows one run of each moduleRejected2017-02-22

Actions
Has duplicate openQA Project - action #17628: test-module doesn't appear if it gets triggered twiceRejected2017-03-09

Actions
Precedes openQA Tests - action #28678: Use new way of loading test modules multiple times without file duplicationResolvedokurz2016-02-02

Actions
Actions

Also available in: Atom PDF