QA » openQA Project

I changed my existing PR to an untested proof of concept https://github.com/os-autoinst/os-autoinst/pull/1895

Is this in progress?

cdywan wrote:

• Make svirt_upload_assets a no-op if the backend implements the functionality https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/13974

./script/openqa-clone-job --within-instance http://openqa.suse.de --skip-deps 7917723 _GROUP=0 CASEDIR="https://github.com/kalikiana/os-autoinst-distri-opensuse.git#svirt_upload_assets_skip"
Created job #7968548: sle-12-SP4-Server-DVD-Updates-s390x-Build20211229-1-mru-install-minimal-with-addons@s390x-kvm-sle12 -> http://openqa.suse.de/t7968548

I put some more verbose thoughts into review comments. Currently I'd describe my progress as follows:

• I'd like to use TDD here, since there was some confusion on the expected behavior of the function, but I'm unsure from reading e.g. qemu code what exactly is expected (e.g. why would svirt need its own image path handling and uploading) and we don't seem to have a test specifically for do_extract_assets.
• I tried to re-use the Qemu module to avoid duplication but I'm not sure it really makes sense to set it up just to convert images - so I'm thinking to split out Qemu:LDriveDevice::gen_qemu_img_convert, if that's all we need

Unfortunately it looks like something went wrong and causes failures in jobs now:

console svirt does not exist at /usr/lib/os-autoinst/backend/baseclass.pm line 686.
    backend::baseclass::console(backend::svirt=HASH(0x10042805f70), "svirt") called at /usr/lib/os-autoinst/backend/svirt.pm line 181
    backend::svirt::do_extract_assets(backend::svirt=HASH(0x10042805f70), HASH(0x10042349640)) called at /usr/lib/os-autoinst/backend/driver.pm line 80
    backend::driver::extract_assets(backend::driver=HASH(0x10042912848), HASH(0x10042349640)) called at /usr/lib/os-autoinst/OpenQA/Isotovideo/Utils.pm line 163
    eval {...} called at /usr/lib/os-autoinst/OpenQA/Isotovideo/Utils.pm line 163
    OpenQA::Isotovideo::Utils::handle_generated_assets(OpenQA::Isotovideo::CommandHandler=HASH(0x10042cb0e78), 1) called at /usr/bin/isotovideo line 409
[2022-01-26T08:26:33.975697+01:00] [warn] !!! bmwqemu::serialize_state: unable to extract assets: Can't call method "name" on an undefined value at /usr/lib/os-autoinst/backend/svirt.pm line 181.
    backend::svirt::do_extract_assets(backend::svirt=HASH(0x10042805f70), HASH(0x10042349640)) called at /usr/lib/os-autoinst/backend/driver.pm line 80
    backend::driver::extract_assets(backend::driver=HASH(0x10042912848), HASH(0x10042349640)) called at /usr/lib/os-autoinst/OpenQA/Isotovideo/Utils.pm line 163
    eval {...} called at /usr/lib/os-autoinst/OpenQA/Isotovideo/Utils.pm line 163
    OpenQA::Isotovideo::Utils::handle_generated_assets(OpenQA::Isotovideo::CommandHandler=HASH(0x10042cb0e78), 1) called at /usr/bin/isotovideo line 409

Edit: Rollback triggered, will propose a fix shortly.

btw, do we still need the auto_review:"unable to extract assets: Can't call method.+name.+on an undefined value":retry in the title?
edit: oh sorry, you just added it

tinita wrote:

btw, do we still need the auto_review:"unable to extract assets: Can't call method.+name.+on an undefined value":retry in the title?
edit: oh sorry, you just added it

For the record, I used host=openqa.suse.de ./openqa-monitor-incompletes to identify affected jobs anyway but put the regex in case I missed one.

The above branch now has test coverage for all uses of the "vmname" and addresses the problem by not relying on the console when assets are being prepared.