Project

General

Profile

action #99663

coordination #64746: [saga][epic] Scale up: Efficient handling of large storage to be able to run current tests efficiently but keep big archives of old results

coordination #99579: [epic][retro] Follow-up to "Published QCOW images appear to be uncompressed"

coordination #99660: [epic] Use more perl signatures in our perl projects

Use more perl signatures - os-autoinst

Added by okurz 2 months ago. Updated 7 days ago.

Status:
In Progress
Priority:
Low
Assignee:
Category:
Feature requests
Target version:
Start date:
2021-10-01
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

Motivation

See #99660. Use signatures to prevent unintended misuses of function signatures, here for os-autoinst


Related issues

Related to openQA Project - action #102146: Deprecate os-autoinst backend::pvmResolved2021-11-092021-11-26

Copied to openQA Project - action #100967: Use more perl signatures - openQAFeedback

History

#1 Updated by okurz 2 months ago

  • Status changed from New to In Progress

#2 Updated by okurz 2 months ago

I had started already here but as I recurringly fail to finish I am splitting this up in multiple PRs for easier testing and planned merges one at a time:

let's see which ones succeed. Based on criticality we can decide which ones to merge first. I suggest to first do low-risk ones like tools and t/, later backends and consoles

EDIT: Updated current status of PRs

#3 Updated by okurz 2 months ago

3 done, 3 to go

#4 Updated by okurz about 2 months ago

#5 Updated by okurz about 2 months ago

additional PR for myjsonrpc only: https://github.com/os-autoinst/os-autoinst/pull/1827 - merged

#6 Updated by okurz 29 days ago

#7 Updated by okurz 23 days ago

I now merged https://github.com/os-autoinst/os-autoinst/pull/1790 "use signatures in os-autoinst backend" as it was ready and has approval. I will have alert duty this week so hopefully I would see any fallout :)

#8 Updated by okurz 19 days ago

There was no feedback on the last merged pull request so I assume we are good and can continue with the next, i.e. "consoles"

#9 Updated by cdywan 7 days ago

okurz wrote:

There was no feedback on the last merged pull request so I assume we are good and can continue with the next, i.e. "consoles"

https://github.com/os-autoinst/os-autoinst/pull/1868

#10 Updated by okurz 7 days ago

I am playing it safe and doing the first part of consoles with https://github.com/os-autoinst/os-autoinst/pull/1868 (merged). https://github.com/os-autoinst/os-autoinst/pull/1789 includes the second part. I realized that a good additional test is to execute the openQA full stack test while I have my signatures changes in os-autoinst checked out locally. Seems like maybe the os-autoinst tests do not cover the complete interface for the interactive mode and such so I will test my changes with openQA first.

Also available in: Atom PDF