Project

General

Profile

Actions

action #104520

open

Move svirt extract_asset code from os-autoinst-distri-opensuse to os-autoinst/backend/svirt.pm size:M auto_review:"unable to extract assets: Can't call method.+name.+on an undefined value":retry

Added by tinita almost 3 years ago. Updated over 2 years ago.

Status:
Workable
Priority:
Low
Assignee:
-
Category:
Feature requests
Target version:
QA (public, currently private due to #173521) - future
Start date:
2021-12-29
Due date:
% Done:

0%

Estimated time:

Description

Observation

The test https://openqa.suse.de/tests/7917723 failed because the code was changed to always execute do_extract_assets when there were PUBLISH_HDD_* settings.
However, do_extract_assets is only implemented in 3 backend classes in os-autoinst currently.

The test in question, svirt_upload_assets.pm implements extract_assets itself, and it does this using the same special setting PUBLISH_HDD_* as os-autoinst:
https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/tests/shutdown/svirt_upload_assets.pm

This only worked because PUBLISH_HDD_ was simply ignored for anything but qemu so far.

The code above should be moved to backend::svirt, and after that we can hopefully remove the check for qemu.

Acceptance criteria

  • AC1: Assets for svirt are published via os-autoinst backend code

Suggestions

  • Remove svirt_upload_assets from the schedule after deploying the new backend code
  • Early return in svirt_upload_assets if the backend method is implement if backend::svirt->can('do_extract_assets')

Related issues 4 (1 open3 closed)

Related to openQA Project (public) - action #76813: [tools] Test using svirt backend fails with auto_review:"Error connecting to VNC server.*: IO::Socket::INET: connect: Connection refused"New2020-10-30

Actions
Related to openQA Project (public) - action #99663: Use more perl signatures - os-autoinst size:MResolvedokurz2021-10-01

Actions
Related to openQA Project (public) - action #105690: s390x svirt jobs incomplete with auto_review:"unable to extract assets:.*/var/lib/libvirt/images/a.img":retryResolvedokurz2022-01-28

Actions
Copied from openQA Project (public) - action #104499: s390 tests fail with backend died: unable to extract assets: Too many arguments for subroutine 'backend::baseclass::do_extract_assetsResolvedlivdywan2021-12-292022-01-13

Actions
Actions

Also available in: Atom PDF