Project

General

Profile

action #104520

Updated by livdywan almost 3 years ago

## Observation 

 The test https://openqa.suse.de/tests/7917723 failed because the code was changed to always execute `do_extract_assets` when there were `PUBLISH_HDD_*` settings. 
 However, `do_extract_assets` is only implemented in 3 backend classes in os-autoinst currently. 

 The test in question, `svirt_upload_assets.pm` implements extract_assets itself, and it does this using the same special setting `PUBLISH_HDD_*` as os-autoinst: 
 https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/tests/shutdown/svirt_upload_assets.pm 

 This only worked because PUBLISH_HDD_ was simply ignored for anything but qemu so far. 

 The code above should be moved to backend::svirt, and after that we can hopefully remove the check for qemu. 

 ## Acceptance criteria 
 * **AC1**: Assets for svirt are published via os-autoinst backend code 

 ## Suggestions 
 - Remove svirt_upload_assets from the schedule after deploying the new backend code 
 - Early return in svirt_upload_assets if the backend method is implement `if backend::svirt->can('do_extract_assets') `

Back