Project

General

Profile

Actions
Copy link

action #97046

closed

Fix flaky coverage - t/05-scheduler-full.t size:M

Added by okurz over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
High
Assignee:
mkittler
Category:
Regressions/Crashes
Target version:
Ready
Start date:
2021-08-03
Due date:
% Done:

0%

Estimated time:

Description

Observation

https://github.com/os-autoinst/openQA/pull/4128 mentions t/05-scheduler-full.t 100.00% <0.00%> (+1.59%) in a clearly unrelated change. I suspect one of

could have caused this.

Acceptance criteria

  • AC1: Stable 100% coverage for t/05-scheduler-full.t

Suggestion

  • Look into the coverage report
  • Ensure to have explicit code coverage for potentially flaky parts
  • Mark offending code as not coverable e.g. # uncoverable statement

Related issues 1 (0 open — 1 closed)

Copied from openQA Project (public) - action #96519: Fix flaky coverage - lib/OpenQA/Scheduler.pm size:MResolvedkraih2021-08-032021-09-04

Actions
Actions
Copy link
 #1

Updated by okurz over 3 years ago

  • Copied from action #96519: Fix flaky coverage - lib/OpenQA/Scheduler.pm size:M added
Actions
Copy link
 #2

Updated by livdywan over 3 years ago

  • Subject changed from Fix flaky coverage - t/05-scheduler-full.t to Fix flaky coverage - t/05-scheduler-full.t size:M
  • Status changed from New to Workable
Actions
Copy link
 #3

Updated by mkittler over 3 years ago

  • Status changed from Workable to In Progress
  • Assignee set to mkittler
Actions
Copy link
 #5

Updated by okurz over 3 years ago

  • Status changed from In Progress to Resolved

PR merged. The coverage in the PR did not change as expected as the coverage as flaky in before. We can resolve immediately as we can reopen if we see flaky coverage again

Actions
Copy link

Also available in: Atom PDF