Actions
action #97046
closedFix flaky coverage - t/05-scheduler-full.t size:M
Description
Observation¶
https://github.com/os-autoinst/openQA/pull/4128 mentions t/05-scheduler-full.t 100.00% <0.00%> (+1.59%)
in a clearly unrelated change. I suspect one of
- https://github.com/os-autoinst/openQA/pull/4072
- https://github.com/os-autoinst/openQA/pull/4095
- https://github.com/os-autoinst/openQA/pull/4096
could have caused this.
Acceptance criteria¶
- AC1: Stable 100% coverage for t/05-scheduler-full.t
Suggestion¶
- Look into the coverage report
- Ensure to have explicit code coverage for potentially flaky parts
- Mark offending code as not coverable e.g.
# uncoverable statement
Updated by okurz about 3 years ago
- Copied from action #96519: Fix flaky coverage - lib/OpenQA/Scheduler.pm size:M added
Updated by livdywan about 3 years ago
- Subject changed from Fix flaky coverage - t/05-scheduler-full.t to Fix flaky coverage - t/05-scheduler-full.t size:M
- Status changed from New to Workable
Updated by mkittler about 3 years ago
- Status changed from Workable to In Progress
- Assignee set to mkittler
Updated by mkittler about 3 years ago
Updated by okurz about 3 years ago
- Status changed from In Progress to Resolved
PR merged. The coverage in the PR did not change as expected as the coverage as flaky in before. We can resolve immediately as we can reopen if we see flaky coverage again
Actions