Project

General

Profile

Actions
Copy link

action #87788

closed

[qe-core][s390x] Additional boot parameters based on workaround or not

Added by skriesch over 4 years ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Bugs in existing tests
Target version:
-
Start date:
2021-01-15
Due date:
% Done:

80%

Estimated time:
Difficulty:
Tags:
qecore-cleanup

Description

We had a discussion in https://bugzilla.suse.com/show_bug.cgi?id=1156053#c59, whether we would require both boot parameters "hardened_usercopy=off" and "hvc_iucv=8" or not.
Developers are saying, that the bug would be fixed. Needles are looking ok.
The workaround of the following if statement is used by openQA, so that both kernel parameters are used and anything is going wrong, so that we have got a SoftFailed as a result.

The used if statement:
if ((is_sle('>=15-SP2') || is_tumbleweed()) && get_var('WORKAROUND_BUGS') =~ 'bsc1156047') {
$params .= ' hardened_usercopy=off hvc_iucv=8';
record_soft_failure('bsc#1156053 - hardened_usercopy=off to avoid "/dev/hvc0: cannot get controlling tty: Operation not permitted" (Kernel memory overwrite attempt detected to SLUB object - illegal operation)');
}

Test with the if statement (based on my PR):
https://openqa.opensuse.org/tests/1589414#

Test without the if statement:
https://openqa.opensuse.org/tests/1589601#

We would have green tests without the workaround. We need a solution, if we would keep the if statement.

Actions
Copy link
 #2

Updated by skriesch over 4 years ago

Interesting! The test with additional kernel parameters has got a timeout failure (referenced in https://progress.opensuse.org/issues/81682) as a result: https://openqa.opensuse.org/tests/1589414#step/system_prepare/5

It seems that anything is going wrong or makes the system unstable with these kernel parameters. Or the timeout is temporary. That has happened without hardened_usercopy=off, too

Actions
Copy link
 #3

Updated by skriesch over 4 years ago

@Sergio Which test version is working correctly in your point of view (with if statement or without the if statement)?

Actions
Copy link
 #4

Updated by SLindoMansilla over 4 years ago

skriesch wrote:

@Sergio Which test version is working correctly in your point of view (with if statement or without the if statement)?

Since it works without the if, the if should be removed :)

Actions
Copy link
 #5

Updated by SLindoMansilla over 4 years ago

I have also removed the setting WORKAROUND_BUGS=bsc1156047 from https://openqa.opensuse.org/admin/machines (s390x-zVM-vswitch-l2)

Actions
Copy link
 #6

Updated by skriesch over 4 years ago

I wanted to know your opinion because it could be that the if statement has got a really important test feature. :)

Actions
Copy link
 #7

Updated by SLindoMansilla over 4 years ago

skriesch wrote:

I wanted to know your opinion because it could be that the if statement has got a really important test feature. :)

No, it was only for the workaround.

But, the setting EXTRABOOTPARAMS: hvc_iucv=8 is still present on https://openqa.opensuse.org/admin/job_templates/34
We have to still investigate why was/is it needed.

Actions
Copy link
 #8

Updated by skriesch over 4 years ago

Should I keep this ticket open because of this topic after the merge of my PR then?

Actions
Copy link
 #9

Updated by SLindoMansilla over 4 years ago

skriesch wrote:

Should I keep this ticket open because of this topic after the merge of my PR then?

Yes, the subject of this ticket also affects that setting, so it would be a good idea to handle it on this ticket too.

Actions
Copy link
 #10

Updated by skriesch over 4 years ago

Actions
Copy link
 #11

Updated by AdaLovelace over 4 years ago

  • Category set to Bugs in existing tests
  • Status changed from New to In Progress
  • % Done changed from 0 to 80
Actions
Copy link
 #12

Updated by okurz over 3 years ago

  • Subject changed from [s390x] Additional boot parameters based on workaround or not to [qe-core][s390x] Additional boot parameters based on workaround or not

I suggest for QE-Core to crosscheck

Actions
Copy link
 #13

Updated by slo-gin over 2 years ago

This ticket was set to Normal priority but was not updated within the SLO period. Please consider picking up this ticket or just set the ticket to the next lower priority.

Actions
Copy link
 #14

Updated by slo-gin about 1 year ago

This ticket was set to Normal priority but was not updated within the SLO period. Please consider picking up this ticket or just set the ticket to the next lower priority.

Actions
Copy link
 #15

Updated by mgrifalconi about 1 year ago

  • Tags set to qecore-cleanup
  • Status changed from In Progress to Resolved
Actions
Copy link

Also available in: Atom PDF