action #80778
open
coordination #102906: [saga][epic] Increased stability of tests with less "known failures", known incompletes handled automatically within openQA
coordination #102909: [epic] Prevent more incompletes already within os-autoinst or openQA
job incompletes with "Virtio terminal and svirt serial terminal do not support send_key", we should change the reason message to be ignored by auto-review, but be clear for the test maintainer
Added by okurz over 3 years ago.
Updated over 2 years ago.
Category:
Feature requests
Description
Observation¶
from https://openqa.suse.de/tests/5138355/file/autoinst-log.txt
[2020-12-06T21:41:33.097 CET] [debug] <<< testapi::send_key(key="ctrl-d", do_wait=0, wait_screen_change=0)
[37m[2020-12-06T21:41:33.098 CET] [debug] Backend process died, backend errors are reported below in the following lines:
Virtio terminal and svirt serial terminal do not support send_key. Use
type_string (possibly with an ANSI/XTERM escape sequence), or switch to a
console which sends key presses, not terminal codes.
at /usr/lib/os-autoinst/backend/baseclass.pm line 787.
Acceptance criteria¶
- AC1: auto-review does not show these issues anymore
- Target version changed from Ready to future
- Related to action #93393: backend died: Virtio terminal and svirt serial terminal do not support send_key added
- Related to deleted (action #93393: backend died: Virtio terminal and svirt serial terminal do not support send_key)
- Has duplicate action #93393: backend died: Virtio terminal and svirt serial terminal do not support send_key added
One addendum from the duplicate ticket:
This issue causes the backend to die and thus also cancels the remaining tests within a scenario. If one test dies within validate_script_output, subsequent tests will not be executed. This might be a problem for scenarios like mau-extratests or extra_tests_textmode, where this issue would effectively reduce the test coverage.
Not an issue now AFAIK, but it might become one in the future.
thank you for including the additional context. IMHO it was suboptimal that the other issue was rejected as duplicate without putting that detail in here.
@ph03nix I would like to help you but I am not clear on what you want to achieve. Do I understand you correctly that you would favor that the openQA job would not incomplete but mark a smaller fraction of the test to be affected? If yes, as here when incorrectly using send_key with control codes in combination with a virtio-terminal is not supported my personal preference is to make such "source code design problems" fatal so that the incorrect code is corrected as soon as possible. This is independant of the wish to have a more intelligent send_key implementation within consoles/serial_screen.pm that would translate something like ctrl-d into the according character code to be used on the serial terminal. Can you clarify what would be your preference?
- Parent task changed from #62420 to #102909
Also available in: Atom
PDF