Project

General

Profile

action #7476

Support comments in tests

Added by coolo about 6 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Feature requests
Target version:
-
Start date:
2015-05-12
Due date:
% Done:

100%

Estimated time:
Difficulty:

Description

We need to add and edit one comment per test - preferably rich text to be able to add links to screenshots


Related issues

Related to openQA Project - action #10212: labels and badges for buildsResolved2016-01-13

Related to openQA Project - action #10148: better notification and user feedbackResolved2015-11-13

History

#1 Updated by coolo about 6 years ago

I forgot to mention: the comments need to have a flag "outdated"

#2 Updated by oholecek about 6 years ago

One comment only? As max. one comment?

#3 Updated by coolo about 6 years ago

Perhaps we shouldn't call it comment - but one "fail reason description" per test :)

#4 Updated by coolo about 6 years ago

In discussion with Ludwig and Anja, I got my mind changed and I added multiple comments per test. How to show that nicely per job group is still up to experiments.

#5 Updated by coolo about 6 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 60

https://github.com/os-autoinst/openQA/pull/373 adds a database model and a start of the UI change.

What's left to do:

  • write test cases
  • hide comments - the database field is there, but that's it
  • show job comments within the job group. right now only job group specific comments are displayed. I'm not so sure how it should look like, but you want to see what test the comment is from

#6 Updated by coolo about 6 years ago

  • Status changed from In Progress to Resolved
  • Assignee set to coolo

#7 Updated by okurz over 5 years ago

  • Status changed from Resolved to Feedback

we have comments and we use them. But the view gets cluttered and many comments are incorrectly rendered and we can not correct them. In discussions I mentioned there should be a "fail reason description" which is exactly what coolo mentioned here https://progress.opensuse.org/issues/7476#note-3
Can we please try to do this? E.g.

One might have remarks about "but we need an unchanged history" but

  • I don't see a benefit of an "unchanged history" of broken comments. Without some hashsum we can never be sure anyway I did not mangle with the database
  • With #7478 we have a history of changes

#8 Updated by okurz over 5 years ago

#9 Updated by okurz over 5 years ago

  • Related to action #10148: better notification and user feedback added

#10 Updated by coolo over 5 years ago

  • Assignee changed from coolo to okurz
  • Target version deleted (Sprint 17)

#11 Updated by RBrownSUSE over 5 years ago

  • Assignee deleted (okurz)

#12 Updated by okurz over 5 years ago

  • Status changed from Feedback to Resolved
  • % Done changed from 60 to 100

ok, comments are not-editable because no one did it yet, not because of "political reasons" or similar. Work on "editable comments" is tracked in #10622 so we can close the current issue again.

Also available in: Atom PDF