Project

General

Profile

Actions

action #63565

closed

The extra setting is added to the new job when cloning a job

Added by Xiaojing_liu about 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Regressions/Crashes
Target version:
Start date:
2020-02-19
Due date:
% Done:

0%

Estimated time:

Description

Observation

When cloning a job use clone_job.pl, the setting with + defined in Medium Types (such as +ISO=xxx.iso) will be added into the job's setting, although it does not affect the job.
Here is an example: https://openqa.suse.de/tests/3795703#settings

Steps to reproduce

  • Add a new setting (e.g +ISO=xxx ) to an exist Medium Types.
  • clone a job with above Medium Types.
  • The new settings

Problem

The settings +ISO=xxx should not be added to the job's setting.


Related issues 4 (0 open4 closed)

Related to openQA Project - action #63883: openqa-clone-job does not support removing an unuseful setting ResolvedXiaojing_liu2020-02-27

Actions
Related to openQA Project - action #64938: '+ISO=' in test suite breaks a number of testsResolvedokurz2020-03-27

Actions
Has duplicate openQA Project - action #63562: The extra setting is added to the new job when cloning a jobClosed2020-02-19

Actions
Copied from openQA Project - action #62219: jobs post does not support to trigger a test suite that is defined in YAML with a new aliasClosedXiaojing_liu2020-01-17

Actions
Actions #1

Updated by Xiaojing_liu about 4 years ago

  • Copied from action #62219: jobs post does not support to trigger a test suite that is defined in YAML with a new alias added
Actions #2

Updated by Xiaojing_liu about 4 years ago

  • Has duplicate action #63562: The extra setting is added to the new job when cloning a job added
Actions #3

Updated by okurz about 4 years ago

Where can I find the clone source job and the cloned ones where the new setting would appear? https://openqa.suse.de/tests/3795703 doesn't tell me if it was cloned or is the source of a clone.

Actions #4

Updated by Xiaojing_liu about 4 years ago

okurz wrote:

Where can I find the clone source job and the cloned ones where the new setting would appear? https://openqa.suse.de/tests/3795703 doesn't tell me if it was cloned or is the source of a clone.

The clone source job is https://10.160.0.207/tests/3767674#settings . job #3795703 was cloned based on job #3767674. you could see that in https://openqa.suse.de/tests/3795703#settings there is a setting '+ISO=SLE-15-SP2-Online-x86_64-Build122.1-Media1.iso'.

Actions #5

Updated by okurz about 4 years ago

ok but wasn't that a feature you added with https://github.com/os-autoinst/openQA/pull/2083 ? The according ticket was #20464

Actions #6

Updated by Xiaojing_liu about 4 years ago

  • Related to action #63883: openqa-clone-job does not support removing an unuseful setting added
Actions #7

Updated by Xiaojing_liu about 4 years ago

okurz wrote:

ok but wasn't that a feature you added with https://github.com/os-autoinst/openQA/pull/2083 ? The according ticket was #20464

Sorry I forgot to update this ticket. Yes, I added this feature before, and I did not consider this situation when I did it.

Actions #8

Updated by livdywan almost 4 years ago

Can this ticket be considered resolved now?

Actions #9

Updated by Xiaojing_liu almost 4 years ago

  • Status changed from New to Resolved
  • Assignee set to Xiaojing_liu

cdywan wrote:

Can this ticket be considered resolved now?

yes, I think so.

Actions #10

Updated by Xiaojing_liu almost 4 years ago

Xiaojing_liu wrote:

cdywan wrote:

Can this ticket be considered resolved now?

yes, I think so.

Related PR had been merged. https://github.com/os-autoinst/openQA/pull/2861

Actions #11

Updated by okurz almost 4 years ago

Please keep in mind that it's a good practice to only resolve a ticket after verifying it works on one of our production instances, e.g. o3 after daily deployment. Maybe you did that already

Actions #12

Updated by Xiaojing_liu almost 4 years ago

  • Status changed from Resolved to Feedback

okurz wrote:

Please keep in mind that it's a good practice to only resolve a ticket after verifying it works on one of our production instances, e.g. o3 after daily deployment. Maybe you did that already

I do not do that in o3. I update the status to 'Feedback'. I plan to verify it on OSD after it is deployed.

Actions #13

Updated by okurz almost 4 years ago

Well that would take a week then with our current schedule of (only) weekly deployments. You can keep it at Resolved, no problem, just a reminder in general :)

Actions #14

Updated by okurz almost 4 years ago

#64938 seems to have been confirmed as regression due to your PR, reverted in https://github.com/os-autoinst/openQA/pull/2874 . Please try to bring in the PR again while testing for the problem as reported in #64938

Actions #15

Updated by okurz almost 4 years ago

  • Related to action #64938: '+ISO=' in test suite breaks a number of tests added
Actions #16

Updated by okurz almost 4 years ago

Remotely related is your PR https://github.com/os-autoinst/openQA/pull/2877 which seems to be a fix for https://github.com/os-autoinst/openQA/pull/2870 which I merged now to fix an urgent problem in production. However I would greatly appreciate if you can ensure we have proper tests to cover the regression we encountered.

Actions #17

Updated by livdywan almost 4 years ago

  • Status changed from Feedback to In Progress
  • Target version set to Current Sprint
Actions #18

Updated by livdywan almost 4 years ago

  • Status changed from In Progress to Feedback
Actions #19

Updated by livdywan almost 4 years ago

  • Status changed from Feedback to Resolved
Actions

Also available in: Atom PDF