Project

General

Profile

action #62480

[qe-core][functional] Implement functions that return the tty number of a console given a name

Added by SLindoMansilla over 1 year ago. Updated 6 months ago.

Status:
Workable
Priority:
Normal
Assignee:
-
Category:
Enhancement to existing tests
Target version:
SUSE QA - Milestone 30
Start date:
2020-01-21
Due date:
% Done:

0%

Estimated time:
42.00 h
Difficulty:

Description

Motivation

At the moment, the TTY numbers are assigned to consoles when they are added (https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/lib/susedistribution.pm#L454)

        $self->add_console('install-shell',  'tty-console', {tty => 2});
        $self->add_console('installation',   'tty-console', {tty => check_var('VIDEOMODE', 'text') ? 1 : 7});
        $self->add_console('install-shell2', 'tty-console', {tty => 9});
        # On SLE15 X is running on tty2 see bsc#1054782
        $self->add_console('root-console',   'tty-console', {tty => get_root_console_tty});
        $self->add_console('user-console',   'tty-console', {tty => 4});
        $self->add_console('log-console',    'tty-console', {tty => 5});
        $self->add_console('displaymanager', 'tty-console', {tty => 7});
        $self->add_console('x11',            'tty-console', {tty => get_x11_console_tty});
        $self->add_console('tunnel-console', 'tty-console', {tty => 3}) if get_var('TUNNELED');

Acceptance criteria

  • AC1: A hash in /lib/Utils/TTY.pm contains the assignment between console names and TTY numbers
  • AC2: /lib/Utils/TTY.pm is properly documented

Considerations

  • Before making code changes, explain the team the idea of implementing this to avoid wasting time on a PR review.

History

#1 Updated by SLindoMansilla over 1 year ago

  • Description updated (diff)

#2 Updated by SLindoMansilla 10 months ago

  • Description updated (diff)
  • Status changed from New to Workable
  • Target version set to Milestone 30
  • Estimated time set to 42.00 h

#3 Updated by jorauch 10 months ago

  • Status changed from Workable to In Progress
  • Assignee set to jorauch

#4 Updated by szarate 10 months ago

  • Status changed from In Progress to Workable

#5 Updated by jorauch 9 months ago

  • Status changed from Workable to Feedback

#6 Updated by tjyrinki_suse 9 months ago

  • Subject changed from [functional][u] Implement functions that return the tty number of a console given a name to [qe-core][functional] Implement functions that return the tty number of a console given a name

#7 Updated by tjyrinki_suse 6 months ago

jorauch szarate Any updated thoughts on reviewing this? Oliver seems to think the ticket is not describing the end goal too clearly, ie what benefit there would be compared to the possibility of using set_tty in special cases.

#8 Updated by szarate 6 months ago

  • Status changed from Feedback to Workable
  • Assignee deleted (jorauch)

PR was closed by stalebot.

Also available in: Atom PDF