Project

General

Profile

Actions
Copy link

action #62480

closed

[qe-core][functional] Implement functions that return the tty number of a console given a name

Added by SLindoMansilla over 4 years ago. Updated about 2 months ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
Enhancement to existing tests
Target version:
SUSE QA - Milestone 30
Start date:
2020-01-21
Due date:
% Done:

0%

Estimated time:
42.00 h
Difficulty:
Tags:
qecore-cleanup

Description

Motivation

At the moment, the TTY numbers are assigned to consoles when they are added (https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/lib/susedistribution.pm#L454)

        $self->add_console('install-shell',  'tty-console', {tty => 2});
        $self->add_console('installation',   'tty-console', {tty => check_var('VIDEOMODE', 'text') ? 1 : 7});
        $self->add_console('install-shell2', 'tty-console', {tty => 9});
        # On SLE15 X is running on tty2 see bsc#1054782
        $self->add_console('root-console',   'tty-console', {tty => get_root_console_tty});
        $self->add_console('user-console',   'tty-console', {tty => 4});
        $self->add_console('log-console',    'tty-console', {tty => 5});
        $self->add_console('displaymanager', 'tty-console', {tty => 7});
        $self->add_console('x11',            'tty-console', {tty => get_x11_console_tty});
        $self->add_console('tunnel-console', 'tty-console', {tty => 3}) if get_var('TUNNELED');

Acceptance criteria

  • AC1: A hash in /lib/Utils/TTY.pm contains the assignment between console names and TTY numbers
  • AC2: /lib/Utils/TTY.pm is properly documented

Considerations

  • Before making code changes, explain the team the idea of implementing this to avoid wasting time on a PR review.
Actions
Copy link
 #1

Updated by SLindoMansilla over 4 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by SLindoMansilla almost 4 years ago

  • Description updated (diff)
  • Status changed from New to Workable
  • Target version set to Milestone 30
  • Estimated time set to 42.00 h
Actions
Copy link
 #3

Updated by jorauch almost 4 years ago

  • Status changed from Workable to In Progress
  • Assignee set to jorauch
Actions
Copy link
 #4

Updated by szarate over 3 years ago

  • Status changed from In Progress to Workable
Actions
Copy link
 #5

Updated by jorauch over 3 years ago

  • Status changed from Workable to Feedback
Actions
Copy link
 #6

Updated by tjyrinki_suse over 3 years ago

  • Subject changed from [functional][u] Implement functions that return the tty number of a console given a name to [qe-core][functional] Implement functions that return the tty number of a console given a name
Actions
Copy link
 #7

Updated by tjyrinki_suse over 3 years ago

@jorauch @szarate Any updated thoughts on reviewing this? Oliver seems to think the ticket is not describing the end goal too clearly, ie what benefit there would be compared to the possibility of using set_tty in special cases.

Actions
Copy link
 #8

Updated by szarate over 3 years ago

  • Status changed from Feedback to Workable
  • Assignee deleted (jorauch)

PR was closed by stalebot.

Actions
Copy link
 #9

Updated by dheidler almost 2 years ago

It's not really clear what the motivation is for this ticket.
Also you should be able to get the tty by getting the console object via backend/baseclass.pm:console().

So I would vote for rejecting this.

Actions
Copy link
 #10

Updated by slo-gin 3 months ago

This ticket was set to Normal priority but was not updated within the SLO period. Please consider picking up this ticket or just set the ticket to the next lower priority.

Actions
Copy link
 #11

Updated by mgrifalconi about 2 months ago

  • Tags set to qecore-cleanup
  • Status changed from Workable to Rejected
Actions
Copy link

Also available in: Atom PDF